Skip to content

♻️ common public interface for managing long_running_tasks #7843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 6, 2025

What do these changes do?

Aligns the public interface exposed by an aiohttp or FastAPI server for managing the lifecycle of a long running task.

This also moves as much of the implementation inside the common servicelib/long_running_tasks instead of the individual servicelib/aiohttp/long_running_tasks and servicelib/fastapi/long_running_tasks modules.

Related issue/s

How to test

Dev-ops

@GitHK GitHK self-assigned this Jun 6, 2025
@GitHK GitHK added this to the Bazinga! milestone Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.27%. Comparing base (4777c9e) to head (d886db0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7843      +/-   ##
==========================================
- Coverage   87.89%   87.27%   -0.62%     
==========================================
  Files        1836     1636     -200     
  Lines       70992    66370    -4622     
  Branches     1219      912     -307     
==========================================
- Hits        62395    57926    -4469     
+ Misses       8254     8182      -72     
+ Partials      343      262      -81     
Flag Coverage Δ
integrationtests 60.37% <ø> (-3.89%) ⬇️
unittests 84.24% <98.33%> (-2.24%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.17% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.17% <98.27%> (+0.36%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (+0.05%) ⬆️
agent 96.29% <ø> (ø)
api_server 91.74% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 85.40% <ø> (-5.70%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 88.44% <ø> (-1.65%) ⬇️
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 88.98% <ø> (+0.10%) ⬆️
storage 87.46% <ø> (-0.15%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.61% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4777c9e...d886db0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK changed the title Long running refactor 3 from2 ♻️ common public interface for managing long_running_tasks Jun 10, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant