🐛 ✨ Check #credits >= 0.0 before returning solver job outputs

services/api-server/src/simcore_service_api_server/api/errors/custom_errors.py

@@ -0,0 +1,37 @@
+import logging
+from urllib.request import Request
+
+from fastapi import status
+from servicelib.error_codes import create_error_code
+from starlette.responses import JSONResponse
+
+_logger = logging.getLogger(__name__)
+
+
+class CustomBaseError(Exception):
+    pass
+
+
+class InsufficientCredits(CustomBaseError):
+    pass
+
+
+class MissingWallet(CustomBaseError):
+    pass
+
+
+async def custom_error_handler(_: Request, exc: CustomBaseError):
+    if isinstance(exc, InsufficientCredits):
+        return JSONResponse(
+            status_code=status.HTTP_402_PAYMENT_REQUIRED, content=f"{exc}"
+        )
+    if isinstance(exc, MissingWallet):
+        return JSONResponse(
+            status_code=status.HTTP_424_FAILED_DEPENDENCY, content=f"{exc}"
+        )
+    error_code = create_error_code(exc)
+    _logger.error("Unexpected error", extra={"error_cose": error_code})
+    return JSONResponse(
+        status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+        content=f"Unexpected server error [OEC: {error_code}]",
+    )

services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py

@@ -38,6 +38,7 @@
 from ..dependencies.rabbitmq import get_log_distributor, get_max_log_check_seconds
 from ..dependencies.services import get_api_client
 from ..dependencies.webserver import AuthSession, get_webserver_session
+from ..errors.custom_errors import InsufficientCredits, MissingWallet
 from ..errors.http_error import create_error_json_response
 from ._common import API_SERVER_DEV_FEATURES_ENABLED, job_output_logfile_responses
 from .solvers_jobs import (
@@ -178,6 +179,19 @@ async def get_job_outputs(
     node_ids = list(project.workbench.keys())
     assert len(node_ids) == 1  # nosec
 
+    product_price = await webserver_api.get_product_price()
+    if product_price is not None:
+        wallet = await webserver_api.get_project_wallet(project_id=project.uuid)
+        if wallet is None:
+            raise MissingWallet(
+                f"Job {project.uuid} does not have an associated wallet."
+            )
+        wallet_with_credits = await webserver_api.get_wallet(wallet_id=wallet.wallet_id)
+        if wallet_with_credits.available_credits < 0.0:
+            raise InsufficientCredits(
+                f"Wallet '{wallet_with_credits.name}' does not have any credits. Please add some before requesting solver ouputs"
+            )
+
     outputs: dict[str, ResultsTypes] = await get_solver_output_results(
         user_id=user_id,
         project_uuid=job_id,

services/api-server/src/simcore_service_api_server/core/application.py

@@ -19,6 +19,7 @@
 from starlette.exceptions import HTTPException
 
 from .._meta import API_VERSION, API_VTAG
+from ..api.errors.custom_errors import CustomBaseError, custom_error_handler
 from ..api.errors.http_error import (
     http_error_handler,
     make_http_error_handler_for_exception,
@@ -108,6 +109,7 @@ def init_app(settings: ApplicationSettings | None = None) -> FastAPI:
     app.add_exception_handler(RequestValidationError, http422_error_handler)
     app.add_exception_handler(HTTPStatusError, httpx_client_error_handler)
     app.add_exception_handler(LogDistributionBaseException, log_handling_error_handler)
+    app.add_exception_handler(CustomBaseError, custom_error_handler)
 
     # SEE https://docs.python.org/3/library/exceptions.html#exception-hierarchy
     app.add_exception_handler(

services/api-server/src/simcore_service_api_server/core/settings.py

@@ -1,5 +1,6 @@
 from functools import cached_property
 from pathlib import Path
+from typing import Any, Mapping
 
 from models_library.basic_types import BootModeEnum, LogLevel
 from pydantic import Field, NonNegativeInt, SecretStr, parse_obj_as
@@ -152,16 +153,23 @@ def debug(self) -> bool:
         """If True, debug tracebacks should be returned on errors."""
         return self.SC_BOOT_MODE is not None and self.SC_BOOT_MODE.is_devel_mode()
 
-    @validator("API_SERVER_DEV_HTTP_CALLS_LOGS_PATH")
+    @validator("API_SERVER_DEV_HTTP_CALLS_LOGS_PATH", pre=True)
     @classmethod
-    def _enable_only_in_devel_mode(cls, v, values):
-        if v and not (
-            values
-            and (boot_mode := values.get("SC_BOOT_MODE"))
-            and boot_mode.is_devel_mode()
-        ):
-            msg = "API_SERVER_DEV_HTTP_CALLS_LOGS_PATH only allowed in devel mode"
-            raise ValueError(msg)
+    def _enable_only_in_devel_mode(cls, v: Any, values: Mapping[str, Any]):
+        if isinstance(v, str):
+            path_str = v.strip()
+            if not path_str:
+                return None
+
+            if (
+                values
+                and (boot_mode := values.get("SC_BOOT_MODE"))
+                and boot_mode.is_devel_mode()
+            ):
+                raise ValueError(
+                    "API_SERVER_DEV_HTTP_CALLS_LOGS_PATH only allowed in devel mode"
+                )
+
         return v
 
 

services/api-server/src/simcore_service_api_server/services/webserver.py

@@ -1,3 +1,5 @@
+# pylint: disable=R0904
+
 import json
 import logging
 import urllib.parse
@@ -11,6 +13,7 @@
 from fastapi import FastAPI, HTTPException
 from httpx import Response
 from models_library.api_schemas_webserver.computations import ComputationStart
+from models_library.api_schemas_webserver.product import GetCreditPrice
 from models_library.api_schemas_webserver.projects import ProjectCreateNew, ProjectGet
 from models_library.api_schemas_webserver.projects_metadata import (
     ProjectMetadataGet,
@@ -24,6 +27,7 @@
     WalletGet,
     WalletGetWithAvailableCredits,
 )
+from models_library.basic_types import NonNegativeDecimal
 from models_library.clusters import ClusterID
 from models_library.generics import Envelope
 from models_library.projects import ProjectID
@@ -468,6 +472,19 @@ async def get_project_wallet(self, project_id: ProjectID) -> WalletGet | None:
             data = Envelope[WalletGet].parse_raw(response.text).data
             return data
 
+    # PRODUCTS -------------------------------------------------
+
+    async def get_product_price(self) -> NonNegativeDecimal | None:
+        with _handle_webserver_api_errors():
+            response = await self.client.get(
+                "/credits-price",
+                cookies=self.session_cookies,
+            )
+            response.raise_for_status()
+            data = Envelope[GetCreditPrice].parse_raw(response.text).data
+            assert data is not None
+            return data.usd_per_credit
+
     # SERVICES -------------------------------------------------
 
     async def get_service_pricing_plan(

services/api-server/src/simcore_service_api_server/utils/client_base_dev.py

@@ -22,9 +22,10 @@ class AsyncClientForDevelopmentOnly(httpx.AsyncClient):
 
     def __init__(self, capture_file: Path, **async_clint_kwargs):
         super().__init__(**async_clint_kwargs)
-        assert capture_file.name.endswith(  # nosec
-            ".json"
-        ), "The capture file should be a json file"
+        if capture_file.is_file():
+            assert capture_file.name.endswith(  # nosec
+                ".json"
+            ), "The capture file should be a json file"
         self._capture_file: Path = capture_file
 
     async def request(self, method: str, url: URLTypes, **kwargs):