Skip to content

fix: validate-tag now compares the current last tag from the current last release #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

fix: validate-tag now compares the current last tag from the current last release #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
160a43c
fix: update tag validation logic in workflow
IShix-g Feb 25, 2025
87fcea3
fix: quote $GITHUB_OUTPUT to prevent potential issues
IShix-g Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/reusable-validate-tag.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,14 @@ jobs:
GH_REPO: ${{ github.repository }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
release_latest=$(gh release list --exclude-drafts --exclude-pre-releases --json tagName,isLatest | jq -r '.[] | select(.isLatest) | .tagName')
[[ -z "$release_latest" ]] && echo "There is not release tag." && echo "validated=true" | tee -a "$GITHUB_OUTPUT" && exit 0
latest_tag=$(git tag --sort=-v:refname | head -n 1)
if [[ -z "$latest_tag" ]]; then
echo "::notice::No tags found in the repository. Skipping validation."
echo "validated=true" | tee -a "$GITHUB_OUTPUT"
exit 0
fi

sorted_latest=$(echo -e "$release_latest\n${{ steps.trim.outputs.normalized-tag }}" | sort -V | tail -n1)
sorted_latest=$(echo -e "$latest_tag\n${{ steps.trim.outputs.normalized-tag }}" | sort -V | tail -n 1)
if [[ "$sorted_latest" == "$release_latest" ]]; then
if [[ "${{ inputs.require-validation }}" == "true" ]]; then
message_type="::error::"
Expand All @@ -102,7 +106,7 @@ jobs:
id: set-validated
run: |
if [ -n "${{ steps.validate-tag.outputs.validated }}" ]; then
echo "validated=${{ steps.validate-tag.outputs.validated }}" >> $GITHUB_OUTPUT
echo "validated=${{ steps.validate-tag.outputs.validated }}" >> "$GITHUB_OUTPUT"
else
echo "validated=${{ steps.validate-format.outputs.validated }}" >> $GITHUB_OUTPUT
echo "validated=${{ steps.validate-format.outputs.validated }}" >> "$GITHUB_OUTPUT"
fi
Loading