nodejs-basics #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenVasileva
reviewed
Feb 1, 2024
| console.log("Create operation complete."); | ||
| } catch (error) { | ||
| if (error.code === "EEXIST") { | ||
| console.error("Error: File already exists."); |
There was a problem hiding this comment.
From task description:
Errorwith messageFS operation failedmust be thrown
(console.log instead of throw error, here and everywhere)
ElenVasileva
reviewed
Feb 1, 2024
There was a problem hiding this comment.
The function doesn't write error message "Error accessing folders:" when source folder doesn't exist
("if files folder doesn't exist Error with message FS operation failed must be thrown")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Scope
File system (src/fs)
+6 create.js - done
+10 copy.js - done
+10 rename.js - done
+6 delete.js - done
+6 list.js - done
+6 read.js - done
Command line interface(src/cli)
+6 env.js - done
+6 args.js - done
Modules(src/modules)
+20 cjsToEsm.cjs - done
Hash (src/hash)
0 calcHash.js - not done
Streams (src/streams)
+10 read.js - done
+10 write.js - done
+10 transform.js - done
Zlib (src/zip)
+10 compress.js - done
+10 decompress.js - done
Advanced Scope
Worker Threads (src/wt) - not done
0 worker.js implemented properly
0 main.js implemented properly
Child Processes (src/cp) - done
+10 spawns child process
+10 child process stdin receives input from master process stdin
+10 child process stdout sends data to master process stdout