Indicate job start and completion #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiCheng45
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Looks good.
Just one thing, I noticed that if you hit "run!" the button goes to the "starting..." state and stops the user from pressing the button. If you quickly change the settings the "starting..." text goes black and you can click it to run another job. Can you update it so that if the user does change the settings then the text changes to "run!" immediately?
|
I changed the button behaviour. It should not allow the reactivation now, as long as the button still says "Starting". Also, if you change parameters to invalid ones, it will actually check if execution should be allowed after the 3 seconds wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Basic mechanism has been added to inform users about job start and objects appearing in other tabs.
closes #593
Fixes
To test
Run a converter. It should highlight the running job tab on start, and trajectory tab on job completion.
Run an analysis. It should highlight the running job tab on start, and plot creator tab on job completion.
Plot the results. Both creating a new plot and sending data to the plot should highlight the plot holder tab.
Check that the tab text and icon get reset correctly when clicked on.