Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iterable unpacking backwards compatible #588

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

MBartkowiakSTFC
Copy link
Collaborator

Description of work
The syntax of PlottingContext for n-dimensional arrays was not handled correctly by Python versions before 3.11.

Fixes

  • replaced the * unpacking operator with a conversion to tuple.

To test
Create and load a 3D data array (Molecular Trace will do it). Using Python 3.9, make sure that you can start the GUI, load the data and plot a 2D slice using the Heatmap plotter.

Copy link
Collaborator

@ChiCheng45 ChiCheng45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've tested on 3.9 and it works fine. The molecular trace plotting is the same on protos and this branch.

@ChiCheng45 ChiCheng45 merged commit d5de48a into protos Oct 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants