-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta release 2024 #573
Beta release 2024 #573
Conversation
…to beta-release-2024
…to beta-release-2024
Looks, good so far. I've found one issue with the project coordinates configurator. For the axial and planar projection, you can input the vector of zeros, this causes the jobs to fail. Also, non-numerical numbers can be entered into the boxes, hitting run doesn't do anything but we should stop the user from entering these like the other configurators. |
The projection widget should work correctly now. |
So far I have found some minor issues (#577, #576, #575 and #574) which I think we need not fix for this release. There is a lammps trajectory conversion failure with the p_lammps_10000 test file from one drive. This does not work on protos either and the issue appears to have been introduced in #546. I tested MDANSE at a98af80 and the conversion works fine at this point. I think we should try to fix this before the release. |
The problem is that LAMMPS has multiple possible formats of the configuration file, and specifically this section: Some of the files conveniently contain a comment after the word 'Atoms' which specified which atom_style is being used. In the long run we should probably aim to support all of them, but there are quite a few possibilities. We can't really rely on the comment being there, and being correct, so some other mechanism of recognising the atom_style will have to be implemented. Having said that, I think I fixed the problem with our example trajectory. It should work again. |
It looks good all my lammps test trajectories work fine now. Can we update the self-part of the van Hove function so that it gives the same error as the distinct part when a simulation without a unit cell is used? This is error in the self-part
This is the error with the distinct-part
|
Looks like #580, #576 and #577 are fixed now. Still one minor visual issue with the q_vector generator is that when you use a vector or range of 4 or more elements the cell in the table is not highlighted. The run button is blocked so it is not much of an issue, so I think we can leave this as it is. |
To address #582 I added placeholder text to the instrument input fields. The values are not very useful (they are all 1) but at least this produces a valid configuration and it is clear what values were used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I think this is ready to be released.
Description of work
Final changes before the beta release of MDANSE 2.
closes #580
closes #579
closes #577
closes #576
closes #582
closes #492
Fixes
To test
Run a DOS job on a trajectory. Check that it reached 100% when finished.
Plot the results of DOS and VACF at the same timer. Switch the plot to Grid. All selected curves should be visible.