Skip to content

Conversation

@iangillingham-stfc
Copy link
Contributor

Description of work

User interface changes to support SCPI mode for Oxford Instruments Mercury IPS magnet controller.
Backward compatible with legacy mode via PV $(P):PROTOCOL.

This is part of an umbrella PR for IOC, support module, GUI and test framework changes.

Ticket

Link to Ticket

Acceptance criteria

Additional tabs, status and control fields available. This has been successfully reviewed and tested by Alex Jones.


Code Review

  • Is the code of an acceptable quality?
  • If the change is to an OPI, does the check_opi_format.py script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?
    The opi check does not pass, but the reasons are not valid in this case and not an error.
  • Do the changes function as described and is it robust?
  • Is there associated PR for the release notes?

Final Steps

@Tom-Willemsen
Copy link
Member

  • In legacy mode, the levels tab disables itself, but the diagnostics & board statuses ones don't (despite their PVs not connecting/being useful in legacy mode). I think those two tabs should also disable themselves.
  • In SCPI mode, on the advanced screen under diagnostics the PVs for current limits and heater current don't connect. If they're not available in SCPI, then those indicators should hide themselves - otherwise the user may get worried by the presence of purple disconnected boxes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually managed to get the opi running under Eclipse - had to reinstall Eclipse 2024. OPI looking good and can confirm the SCPI tabs disable when in LEGACY mode.

@Tom-Willemsen Tom-Willemsen merged commit 5967f96 into master Oct 16, 2025
8 checks passed
@Tom-Willemsen Tom-Willemsen deleted the Ticket8614_mercury_IPS_magnet_supply branch October 16, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants