fix manual system test

[rerpha]

Description of work

This now uses a PeriodGoodFramesWaiter which adds dae.period.good_frames instead of dae.good_frames.

Ticket

None, found during manual system tests for IBEX release 25.8.0

Labels

Add appropriate label(s) to this PR

• 'bluesky-Semver-Major' - Breaking Change
• 'bluesky-Semver-Minor' - New feature
• 'bluesky-bug' - Bug fix
• 'bluesky-documentation' - Document Changes
• 'bluesky-ignore-for-release' - Do not show in the release notes

Labels can be found of the right-hand sidebar of this PR once created

Acceptance criteria

• Pull request title is understandable for a user (e.g. scientist) reading the release notes. The PR title should be a short description of the change from a user perspective.
• Pull request has appropriate labels for automatic release-notes generation

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer

[Tom-Willemsen]

Was this in release notes - that anyone that was previously using PeriodGoodFramesWaiter needs to adjust their outer plan with different signal names? The release notes for the removal itself don't make that obvious.

[rerpha]

Was this in release notes - that anyone that was previously using PeriodGoodFramesWaiter needs to adjust their outer plan with different signal names? The release notes for the removal itself don't make that obvious.

I don't think I realised. we can probably add it back as a stub?

[Tom-Willemsen]

Or check if anyone was actually doing this - argus/chronus/rikenfe/polref/zoom/loq would likely cover it, maybe crisp/hifi too but they are on much older deploys and will need other work to bring them back up-to-date anyway.

[Tom-Willemsen]

Plus side - the manual tests caught a legitimate problem :)