typo #206
Merged
typo #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerpha
added
the
bluesky-ignore-for-release
| ### `ibex_bluesky_core` devices | ||
| - `BlockRw` and `SimpleDae`: `ibex_bluesky_core` as it's completely general / useful to all beamlines | ||
| - `ReflParameter`: in `ibex_bluesky_core.devices.reflectrometry` because it's useful across all reflectometers | ||
| - `ReflParameter`: in `ibex_bluesky_core.devices.reflectometry` because it's useful across all reflectometers |
Member
There was a problem hiding this comment.
If we used the:
{py:obj}`ibex_bluesky_core.devices.reflectometry`
syntax sphinx would have caught this for us...
Tom-Willemsen
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Add your own description here
Ticket
Link to Ticket
Labels
Add appropriate label(s) to this PR
Labels can be found of the right-hand sidebar of this PR once created
Acceptance criteria
List the acceptance criteria for the PR. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer