use blockrw for motor scan instead of block_mot #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Willemsen <tom.willemsen@stfc.ac.uk>
… IDE auto __all__ insertion
Tom-Willemsen
approved these changes
May 1, 2025
danielmaclaren
added
bluesky-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the motor_scan() and motor_adaptive_scan() consturct a BlockRw using the global moving flag. this change is required as if you try and use motor_scan() over something that is using axis.cmd it doesn't have all of the motor fields and then fails to connect to a load of fields that don't exist. this is what the SANS instruments want to do for most cases, so i think we should cater for it.