Consolidate imports #174
Merged
Consolidate imports #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gGroup/ibex_bluesky_core into consolidate_imports
Tom-Willemsen
requested changes
Apr 2, 2025
Member
Tom-Willemsen
left a comment
Tom-Willemsen
left a comment
There was a problem hiding this comment.
first pass, not done any functional testing yet
Member
|
Was there a matching PR/branch for |
Contributor
Author
yes, i definitely forgot to push it and didn't do it just now: ISISComputingGroup/system_tests#128 |
Member
|
Sphinx build says ❌ with latest merge - mind having a look? |
rerpha
force-pushed
the
consolidate_imports
branch
from
65ec2c6 to
d215587
Compare
Tom-Willemsen
approved these changes
Apr 14, 2025
Member
Tom-Willemsen
left a comment
Tom-Willemsen
left a comment
There was a problem hiding this comment.
In summary, these changes are aligned with best practices in software development to:
Improve maintainability and readability.
Clearly define the module's public API.
Enhance functionality by adding new features.
Organize the codebase into logically separated components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #68
This is a large breaking change.
Main highlights are:
__init__.pyof callbacks__init__.pys for modules to the top level, named the same as their modules - though this shouldn;'t make a difference from a user-facing perspective as the import looks the same