Ticket8523 remove use of arrange #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chsudeepta
requested changes
Dec 6, 2024
| (i >= stop) and (i <= start) | ||
| ): # Check inserted here to ensure scan remains within defined range | ||
| yield i | ||
|
|
Contributor
There was a problem hiding this comment.
Can we move the logic to convert step size to number of steps in one utility method and use in all files instead of duplicating the logic?
Chsudeepta
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved EMU tests to test Emulooptime and corrected them instead as emu is no longer a script definition.
Then removed use of arrange by replacing it by calling linspace where the number of steps is calculated using the arrange step size.
Then applied pyright and ruff fixes