Skip to content

Conversation

@FreddieAkeroyd
Copy link
Member

Description of work

Add local changes from CRISP as look like they are intentional


Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks Oct 30, 2025
Comment on lines +52 to +55
#asynSetTraceIOMask("$(XPS_PORT)00", -1, 0x2)
#asynSetTraceMask("$(XPS_PORT)00", -1, 0x9)
#asynSetTraceIOMask("$(XPS_PORT)01", -1, 0x2)
#asynSetTraceMask("$(XPS_PORT)01", -1, 0x9)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can readd this very easily if needed - i don't think it should live in source code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we should have such things conditional as in $(TRACE_PORT=#) asynSetTraceIOMask("$(XPS_PORT)00", -1, 0x2) so debugging is easy to turn on when needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Flash Review

Development

Successfully merging this pull request may close these issues.

3 participants