Skip to content

Conversation

@adalator
Copy link
Contributor

@adalator adalator commented Apr 9, 2020

Description of work

Added a macro to DFKPS_01 called DISABLE_AUTOONOFF which disables the AUTOONOFF PV, preventing it from being set.

To test

ISISComputingGroup/IBEX#5268

Acceptance criteria

  • When DISABLE_AUTOONOFF is set to 1, AUTOONOFF cannot be set via caput
  • When DISABLE_AUTOONOFF is set to 0, AUTOONOFF can be set via caput

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@Alistair-McGann-Tessella Alistair-McGann-Tessella merged commit 963396c into master May 20, 2020
@Alistair-McGann-Tessella Alistair-McGann-Tessella deleted the Ticket5268_danfysik_hide_autoonoff branch May 20, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants