Skip to content

Conversation

@rerpha
Copy link
Contributor

@rerpha rerpha commented Oct 30, 2025

I haven't copied history here but it's a vendor emulator and some exe files...

linked to ISISComputingGroup/EPICS-DeviceEmulator#187 - please merge alongside this.

we may make deviceemulator pip-installable, so this makes that change easier. I'm not going to start fixing all the ruff stuff as i'd rather keep the file same for now.

@FreddieAkeroyd
Copy link
Member

Should we leave non lewis emulators in the DeviceEmulators module? One of the rational for moving lewis emulators to lewis itself was for non-epics use, wouldn't the same situation apply to non-lewis emulators too?

@rerpha
Copy link
Contributor Author

rerpha commented Nov 4, 2025

I was going to make deviceemulator into a lewis-devices pip-installable package (ISISComputingGroup/EPICS-DeviceEmulator#189), so didn't want to include stuff that wasn't related. i can move out to a separate module, but thought it might be better off here? maybe we need an other_emulators repo?

@FreddieAkeroyd
Copy link
Member

I'm just coming from the "consistent approach" angle - if we feel having lewis emulators outside of the ioc test framework/support modules is better for sharing, isn't the same true for non-lewis emulators we create? So maybe a other_emulators module is needed if DeviceEmulators is being repurposed as lewis only. Just a though - maybe we could

  • git mirror DeviceEmulators to LewisDevices
  • remove other emulators from LewisDevices
  • remove lewis from DeviceEmulators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants