Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/4959-Support-By-Category-and-Folder-Grouping #9204

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Nov 30, 2022

What this PR does / why we need it: This PR is an update to the original work in #5485 from QDR in 2019 that added a 'Group by Folder' option for the main dataset file table and an optional 'Goup By Category' option. These work in consort with the main sort options and do a presort/grouping of the files by Category tag (e.g. Documentation, Data, Code, custom tags) and/or Folder before the alphabetical, by age, etc. sorting is done.

Which issue(s) this PR closes:

Closes #4959
Closes #6933

Special notes for your reviewer:
The original work has been in production in QDR since 2019 but was dropped from consideration by IQSS in anticipation of further analysis of other possible options. Since then JHU and ASU have requested this functionality and JHU has supported updating the original branch via GDCC.

Suggestions on how to test this:

  • Set the :CategoryOrder setting to something like "Documentation, Data, Code"
  • In a dataset with multiple files, sprinkle some category tags and directory path entries
  • Verify that the display order puts Documentation first (all files with that tag sorted according to current sort direction) followed by Data (again sorted in that group), etc. and that all files with a folder path appear after the group with no path.
  • Verify that setting :OrderByFolder false turns off the by folder sorting
  • Set :AllowUserManagementOfOrder true and
    • Verify that turning the group by toggles on/off turn the groupings on/off
    • Verify that going to page 2 etc with more files or to/from the tree view doesn't mess with the group by checkbox displays or the grouping that is enabled.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
image

The image shows the two new Group-By-Folder and Group-By-Tag checkbox selectors and shows some of the effect of the tag sort - the second file with the Data tag would normally be third in alphabetical order but has been pulled up to be before untagged files. (Not shown - a file in the /test sub-folder is now last in the list instead of in the top 3 files due to the group-by-folder setting.)

Is there a release notes update needed for this change?: in the PR

Additional documentation:

qqmyers and others added 11 commits January 23, 2019 17:56
Conflicts:
	src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
…_Dataset_page' of https://github.com/QualitativeDataRepository/dataverse.git into 4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
@coveralls
Copy link

coveralls commented Nov 30, 2022

Coverage Status

Coverage: 20.171% (-0.01%) from 20.184% when pulling e928ff0 on QualitativeDataRepository:4959-Allow_installations_to_determine_order_of_files_on_Dataset_page into e4961fe on IQSS:develop.

4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
@qqmyers qqmyers changed the title IQSS/4959-Support-By-Category-and-Folder-Presorting IQSS/4959-Support-By-Category-and-Folder-Grouping Nov 30, 2022
@qqmyers qqmyers added the Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) label Dec 14, 2022
@scolapasta scolapasta added this to the 5.14 milestone Jan 25, 2023
…ions_to_determine_order_of_files_on_Dataset_page
…ions_to_determine_order_of_files_on_Dataset_page
@rtreacy rtreacy self-assigned this Apr 26, 2023
Copy link
Contributor

@rtreacy rtreacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked as per instructions. Both checkboxes checked, unchecked Group By Folder, Grouped By Tag in all combinations. Checked Tree view always maintains folder order

@rtreacy rtreacy removed their assignment Apr 26, 2023
@kcondon kcondon self-assigned this May 2, 2023
@kcondon
Copy link
Contributor

kcondon commented May 2, 2023

Issues found:
1.:CategoryOrder doesn't appear to have an effect.
2. If user level sort is enabled, tag sorting is always in Data, Code, Doc order, ignores CategoryOrder.
3. Type sort doesn't seem to work correctly but this is preexisting.

@pdurbin
Copy link
Member

pdurbin commented May 2, 2023

:CategoryOrder

Wait, is a new database setting slipping in? Shouldn't this be MPCONFIG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDCC: JHU GDCC: QDR of interest to QDR Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)
Projects
Status: No status
6 participants