-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IQSS/4959-Support-By-Category-and-Folder-Grouping #9204
IQSS/4959-Support-By-Category-and-Folder-Grouping #9204
Conversation
Conflicts: src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
…_Dataset_page' of https://github.com/QualitativeDataRepository/dataverse.git into 4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
IQSS/7349-4_creator_updates
…ions_to_determine_order_of_files_on_Dataset_page
…ions_to_determine_order_of_files_on_Dataset_page
…ions_to_determine_order_of_files_on_Dataset_page
…_Dataset_page' of https://github.com/QualitativeDataRepository/dataverse.git into 4959-Allow_installations_to_determine_order_of_files_on_Dataset_page
…ions_to_determine_order_of_files_on_Dataset_page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked as per instructions. Both checkboxes checked, unchecked Group By Folder, Grouped By Tag in all combinations. Checked Tree view always maintains folder order
Issues found: |
Wait, is a new database setting slipping in? Shouldn't this be MPCONFIG? |
What this PR does / why we need it: This PR is an update to the original work in #5485 from QDR in 2019 that added a 'Group by Folder' option for the main dataset file table and an optional 'Goup By Category' option. These work in consort with the main sort options and do a presort/grouping of the files by Category tag (e.g. Documentation, Data, Code, custom tags) and/or Folder before the alphabetical, by age, etc. sorting is done.
Which issue(s) this PR closes:
Closes #4959
Closes #6933
Special notes for your reviewer:
The original work has been in production in QDR since 2019 but was dropped from consideration by IQSS in anticipation of further analysis of other possible options. Since then JHU and ASU have requested this functionality and JHU has supported updating the original branch via GDCC.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
The image shows the two new Group-By-Folder and Group-By-Tag checkbox selectors and shows some of the effect of the tag sort - the second file with the Data tag would normally be third in alphabetical order but has been pulled up to be before untagged files. (Not shown - a file in the /test sub-folder is now last in the list instead of in the top 3 files due to the group-by-folder setting.)
Is there a release notes update needed for this change?: in the PR
Additional documentation: