Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: For back-end stores using something like Oxford Common File Layout to deduplicate files across versions, the archival info for all prior dataset versions has to be in place before you can add the next/latest version. This PR adds a feature flag to turn on this behavior and adds code to check/fail if earlier versions haven't successfully been archived. It also avoids showing a submit button for a version in the dataset page version table if there's no chance of success (because earlier versions aren't archived).
Which issue(s) this PR closes:
DANS issue 2097
Special notes for your reviewer:
Suggestions on how to test this: Set the flag, verify the datasetpage version table doesn't show a submit button for v2+ if you haven't archived v1. Verify an archiving post-publish workflow fails for new versions if v1 hasn't succeeded. (Probably easiest to delete the archival status of v1 via API, but could just configure the workflow after publishing v1).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: