Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The original code (from 8 yrs ago) was doing an em.merge and em.flush after every file PID update. This PR uses the merged dataset (which should assure the files are merged) and relies on the automatic flush at the end of the transaction instead, avoiding the extra db traffic.
Which issue(s) this PR closes:
Special notes for your reviewer: FWIW: I have not tried to perf test this to know if it is significant but it seems like useful cleanup.
Suggestions on how to test this: ~regression test - file pids and the globalidcreatetime updated on them when the /api/datasets//modifyRegistrationMetadata is called or when the update-current-version option is used for publication as before, recognizing that the code now checks to make sure the DataCite xml is different before updating it so some change to the list of dataset creators, or file name, mimetype is needed. Adding an extra author/creator is probably the easiest test.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: seems pretty small to be listed in the notes
Additional documentation: