Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: While working on archiving, I noticed occasional warnings related to the netty library (see #12108). In looking into that w/AI, I saw that a) we were closing the s3Presigner after use while also caching it for reuse, b) that we were not closing the presigners and clients at shutdown, and c) were not using the latest aws sdk.
This PR fixes all of these but, as far as I can tell, does not resolve #12108 itself. Nevertheless, it seems like these are useful updates to have.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: regression/auto-tests only. Check for the "Closing all S3 clients and transfer managers." log when shutting Dataverse/Payara down.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: