Call Archiving commands asynchronously from UI to avoid timeouts#12101
Open
qqmyers wants to merge 5 commits intoIQSS:developfrom
Open
Call Archiving commands asynchronously from UI to avoid timeouts#12101qqmyers wants to merge 5 commits intoIQSS:developfrom
qqmyers wants to merge 5 commits intoIQSS:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When archiving takes too long (e.g. a 10K file dataset), launching it from the UI can cause a timeout/rollback. This PR updates the code to archive a version from the versions table to run asynchronously and to handle any OptimisticLockException if the dataset changes before the archiving in the background completes.
Which issue(s) this PR closes:
Special notes for your reviewer:
FWIW: This is one of several PRs related to updates being done to improve archiving scalability at QDR and DANS. Some are relatively minor cleanup while others are more significant. I'm submitting them all to avoid drift in QDR's fork and to leverage QDR testing (where all of these are being tested together).
Note: - another PR is coming that will use the asyncCommand call when doing an 'Update-Current-Version' publish action.
Suggestions on how to test this: Regression - confirm that calling an archiving workflow from the versions table still works. Not sure it's practical to try archiving something big enough to see the timeout issue with the current code.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Will create an aggregate one.
Additional documentation: