Merged
Conversation
stevenwinship
approved these changes
Nov 4, 2025
Contributor
|
@qqmyers Could you please resolve the conflicts and sync up the branch. (the conflicts are in the changelog and trivial) |
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The original PR did not use a valid method for determining whether the store supports directUpload. This PR addresses that, along with making several other minor improvements:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Call these apis for datasets/dataverses and verify that the correct store is returned and that the values match what is set (e.g. as jvm-options).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: