Merged
Conversation
github-actions
bot
added
FY25 Sprint 19
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
pdurbin
reviewed
Mar 24, 2025
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't run the code but it looks fine and tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11359/1/testReport/
I left a couple comments about the docs.
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
approved these changes
Mar 24, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
Tests Passed, Merging PR |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Contributor
|
@stevenwinship Hi Steven, I tried |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The post files/{fileId}/metadata/tabularTags api could only add tags and categories, instead of edit(like remove or replace). This PR adds the ability to overwrite the list with a new list.
Which issue(s) this PR closes:#11292
Special notes for your reviewer:
Suggestions on how to test this: Test api with and without ?replace=
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: