Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookups of Harvested datasets with lower-case versions of persistent identifiers in the database #11003

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Nov 6, 2024

What this PR does / why we need it: The recent changes to support lower case shoulders in #10708 accidentally broke retrieval of harvested datasets with lowercase DOIs (which is newly possible with DataCite as the Harvesting source). This fix stores harvested DOIs in their original case (useful if the harvesting source is not case-insensitive even though it should be) but changes to using case-insensitive DB queries so case-insensitive retrieval works.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: Verify that the dataset page works for DOIs when the db identifier for it is in lower/mixed case in the database. This only happens naturally when Harvesting from a source that provides a lower/mixed case DOI. To test, editing the db entry for a normal/internal DOI would work. Regression testing - datasets with normal DOIs, PermaLinks, Handles as the identifier/alternative identifier should continue to work and be case insensitive (i.e. one can change the dataset page URL to use lowercase letters and it should still work.)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Will use upper case form of DOI identifier to support case-insensitive
retrieval
@coveralls
Copy link

coveralls commented Nov 6, 2024

Coverage Status

coverage: 21.856%. remained the same
when pulling b8c0c40 on GlobalDataverseCommunityConsortium:HarvestDatasetUsingPID
into e208eed on IQSS:develop.

…iers, making the searches case-insensitive and making it possible to look up any lower case or mixed-case persistent ids already in the database. IQSS#11003
@landreev landreev changed the title Harvesting - Case-insensitive DOIs Fix lookups of Harvested datasets with lower-case versions of persistent identifiers in the database Nov 7, 2024
@qqmyers qqmyers marked this pull request as ready for review November 7, 2024 17:36
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Nov 7, 2024
@stevenwinship stevenwinship self-assigned this Nov 7, 2024
@stevenwinship stevenwinship removed their assignment Nov 7, 2024
@cmbz cmbz added the FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) label Nov 7, 2024
@landreev
Copy link
Contributor

landreev commented Nov 8, 2024

@qqmyers @stevenwinship thank you for the extra effort with the index, etc.

@landreev landreev merged commit 61b8046 into IQSS:develop Nov 8, 2024
12 checks passed
@landreev landreev deleted the HarvestDatasetUsingPID branch November 8, 2024 18:59
@pdurbin pdurbin added this to the 6.5 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

6 participants