Intellij IDEA webapp hotreload #10247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowedApiCalls should be at the top level, not inside toolParameters.
Without this it also evaluates the FILE case causing NPE when dataFile is accessed.
# Conflicts: # src/main/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandler.java
…ocker
When running Dataverse in Docker we still want to be able to just edit
things under src/main/webapp and then just reload the web page to see the
changes. To do this:
1. Mapped Payara /opt/payara/appserver/glassfish/domains/domain1/applications
folder to ./docker-dev-volumes/glassfish/applications
2. Added watchers.xml File watcher configuration, which can be imported into
IDEA to ...
3. ... run cpwebapp.sh to copy changed files under src/main/webapp to
./docker-dev-volumes/glassfish/applications/dataverse-{current version}
pdurbin
reviewed
Jan 22, 2024
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
pdurbin
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is related to #9959.
When running Dataverse in Docker we still want to be able to just edit things under
src/main/webappusing IntelliJ IDEA and then just reload the web page to see the changes. To do this in this PR:/opt/payara/appserver/glassfish/domains/domain1/applicationsfolder to./docker-dev-volumes/glassfish/applicationswatchers.xmlFile watcher configuration, which can be imported into IDEA to ...cpwebapp.shto copy changed files under src/main/webapp to./docker-dev-volumes/glassfish/applications/dataverse-{current version}Which issue(s) this PR closes:
None.
Special notes for your reviewer:
You need IntelliJ IDEA Ultimate edition for File watchers support.
Suggestions on how to test this:
scripts/intellij/watchers.xmlinto File watchers (https://www.jetbrains.com/help/idea/settings-tools-file-watchers.html).src/main/webapp.See this here in action: https://harvard.zoom.us/rec/share/EUOqzaq4NzsH4N8xX7kg9II8w292MEB6eqbyzPMlZOACsErKV-Z20hHBj1HerFH2.bGFh04EdU1Qnu9ic
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes.
Additional documentation:
The documentation for this is practically what is written in
Suggestions on how to test this.