-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add displayOrder, typeClass and isRequired fields to DatasetFieldType payload #10225
Merged
stevenwinship
merged 5 commits into
develop
from
10216-metadatablocks-payload-extension
Jan 22, 2024
Merged
Add displayOrder, typeClass and isRequired fields to DatasetFieldType payload #10225
stevenwinship
merged 5 commits into
develop
from
10216-metadatablocks-payload-extension
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
GPortas
added
Size: 3
A percentage of a sprint. 2.1 hours.
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
SPA
These changes are required for the Dataverse SPA
labels
Jan 11, 2024
sekmiller
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just made a fix to a typo in the release note
This comment has been minimized.
This comment has been minimized.
I have added another required field to the payload so I have moved this PR back to ready for review. |
GPortas
changed the title
Add displayOrder and isRequired fields to DatasetFieldType payload
Add displayOrder, typeClass and isRequired fields to DatasetFieldType payload
Jan 17, 2024
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
sekmiller
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Size: 3
A percentage of a sprint. 2.1 hours.
SPA
These changes are required for the Dataverse SPA
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The API endpoint
/api/metadatablocks/{block_id}
has been extended to include the following fields:isRequired
- Wether or not this field is requireddisplayOrder
: The display order of the field in create/edit formstypeClass
: The type class of this field ("controlledVocabulary", "compound", or "primitive")Which issue(s) this PR closes:
Suggestions on how to test this:
curl http://localhost:8080/api/v1/metadatablocks/citation
See how citation fields subJson contains the new 'isRequired' and 'displayOrder' fields.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Yes.