Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Vagrant #9838

Closed
pdurbin opened this issue Aug 28, 2023 · 0 comments · Fixed by #9839
Closed

remove Vagrant #9838

pdurbin opened this issue Aug 28, 2023 · 0 comments · Fixed by #9839
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Aug 28, 2023

I sent the following message ( https://groups.google.com/g/dataverse-community/c/y1_JCWN44II/m/FFjQTkJ4AwAJ ) a couple weeks ago:

From: Philip Durbin philip_durbin@harvard.edu
Date: Mon, 14 Aug 2023 16:38:21 -0400
Subject: Vagrant on chopping block
To: dataverse-community@googlegroups.com

I added a Vagrant environment way back in the DVN 3 days but it's become a
bit of a maintenance burden.

We're in the middle of bumping the version of Payara, Java, and Solr. Each
time, we go back to the Vagrant scripts and tweak them.

These days I've switched to Docker and I don't even have Vagrant installed
on my three year old laptop. I think I've convinced myself to just delete
Vagrant stuff from the code base.

I'm writing mostly to give a heads up. If anyone out there wants to
maintain the Vagrant code, maybe it can be moved to another repo? If you
have an opinion about Vagrant, please let me know.

Thanks,

Phil

p.s. Here's our current writeup of Vagrant:
https://guides.dataverse.org/en/5.14/developers/tools.html#vagrant

As implied above, these days we're encouraging Docker instead:
https://guides.dataverse.org/en/5.14/container/dev-usage.html

--
Philip Durbin
Software Developer for http://dataverse.org
http://www.iq.harvard.edu/people/philip-durbin

There were no objections and it has been annoying to fiddle with Vagrant files while we upgrade Payara and Solr. We aren't even testing the Vagrant changes (it would have complained about the Java 17 upgrade if we had). I don't even have Vagrant installed. Let's remove it. It will reduce the number of files we need to change when upgrade Java, Payara or Solr.

If people really want to use Vagrant they can probably use https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/develop/Vagrantfile or create their own repo.

@pdurbin pdurbin added this to the 6.0 milestone Aug 28, 2023
pdurbin added a commit that referenced this issue Aug 28, 2023
pdurbin added a commit that referenced this issue Aug 28, 2023
The download.sh script was originally added in 294006e
to support Vagrant in but now that we have removed Vagrant,
it is unnecessary.

We are moving the entire "downloads" directory, including
Stata14TestFile.dta, which isn't used by any test. It was added
in 9e7c40b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant