Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request/Idea: Indicate on dataset page when dataset version has no license or custom terms #8796

Open
jggautier opened this issue Jun 13, 2022 · 9 comments · Fixed by #10614
Labels
Feature: Terms & Licensing Size: 3 A percentage of a sprint. 2.1 hours.
Milestone

Comments

@jggautier
Copy link
Contributor

jggautier commented Jun 13, 2022

Overview of the Feature Request
For datasets that have no explicit license or custom terms, indicate on dataset page that the dataset has no license or custom terms instead of indicating that there are custom dataset terms.

What kind of user is the feature intended for?
Curator, Depositor, Guest

What inspired the request?
Reviewing the license and terms metadata of datasets in the Harvard Dataverse Repository, I noticed that on the landing page of dataset versions that have no license or terms metadata, there's a link that indicates that the dataset has custom terms, such as dataset versions that depositors using the Dataverse APIs are able to create and publish with no license or terms and dataset versions created before the "multiple license" update was applied to the Harvard repository, including https://dataverse.harvard.edu/dataset.xhtml?persistentId=doi:10.7910/DVN/0SZMZQ&version=2.0:

Screen Shot 2022-06-13 at 11 47 18 AM

This seems misleading to me. Is it fair to say that a dataset version with no license or terms has custom terms?

What existing behavior do you want changed?
For dataset versions that have no license or terms set, indicate that on the dataset page instead of indicating that there are custom terms.

Earlier discussions about the multiple license update included indicating that no license or terms were set when creating a dataset version. Here's an image from early mockups:

Screen Shot 2022-06-13 at 11 57 31 AM

This was abandoned after we decided that the update would also prevent depositors from creating a dataset with no license or terms, so the "Publish Dataset" dialogue would never need to show that red message, since it wouldn't be possible through the UI to create and publish a new dataset without a license or custom terms of use.

Any brand new behavior do you want to add to Dataverse?
For dataset versions with no license or terms, indicate that the version has no license or terms instead of indicating that it has custom terms, perhaps using the text "No license or terms chosen"

Any related open or closed issues to this feature request?
#7440
#7742

@qqmyers
Copy link
Member

qqmyers commented Jun 13, 2022

FWIW: Technically the message above for Terms of Use ("This dataset is made available without...") is an entry in the database in the termsofuse column of the termsofuseandaccess row for that dataset version, i.e. it is not a standard message stored elsewhere, hence it technically does have custom terms. The language could be changed for published datasets by editing the db.
Actually allowing published datasets to not have a license or custom terms would be a real design change, towards one that I think was problematic for people. Perhaps an option to allow legacy datasets to not have any license but still require publishing to set set something might be an acceptable compromise.
Another variation might be to include a short clip from the terms in the current case, i.e. above the fold you'd see Custom Terms: "This dataset is made available without..." (or other 1-2 line snippet.) That would perhaps improve clarity without changing the design.

@jggautier
Copy link
Contributor Author

jggautier commented Apr 22, 2024

#10513 might be related.

@sbarbosadataverse
Copy link

sbarbosadataverse commented Apr 24, 2024

also related to #8798

prioritize to size*

@cmbz
Copy link

cmbz commented May 8, 2024

2024/05/08

  • Size 3 for documentation and license json, active = False for this license so that it doesn't appear in the dropdown when depositors are choosing pre-defined terms.
  • Create additional dataverse.harvard.edu issue to create database script to locate affected datasets and update with special text.

@cmbz cmbz moved this from SPRINT- NEEDS SIZING to SPRINT READY in IQSS Dataverse Project May 8, 2024
@sekmiller sekmiller moved this from SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project May 22, 2024
@sekmiller sekmiller moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Jun 3, 2024
@sekmiller sekmiller self-assigned this Jun 3, 2024
sekmiller added a commit that referenced this issue Jun 5, 2024
sekmiller added a commit that referenced this issue Jun 5, 2024
sekmiller added a commit that referenced this issue Jun 5, 2024
@sekmiller sekmiller removed their assignment Jun 7, 2024
@jggautier
Copy link
Contributor Author

jggautier commented Jun 20, 2024

@sekmiller or @cmbz, from @qqmyers's comment in the PR related to this issue, it sounds like what was done is different than what @cmbz wrote would be done last month.

Could you confirm this here and write about why the approach taken was different?

I'm curious about why the approach changed and would like to help make sure that this GitHub issue reflects how we wound up addressing the issue.

landreev added a commit that referenced this issue Jul 17, 2024
…ts harvested in oai_dc, and not break anything else... I think? #8796
@pdurbin pdurbin added this to the 6.4 milestone Jul 18, 2024
@jggautier
Copy link
Contributor Author

jggautier commented Jul 23, 2024

The pull request at #10614 was merged into the develop branch and this GitHub issue was closed with it, although from what I could tell in that PR, what @cmbz wrote would be done was not done, and something else was done.

I looked through the files changed in the PR to understand what was done, but I couldn't tell.
And I tried spinning up a Dataverse instance on AWS based on the develop branch to experience the changes, but the instance was inaccessible. @sekmiller wrote in the release notes that "when datasets have neither a license nor custom terms of use the display will indicate this."

@sekmiller, @landreev, or @cmbz, could you help me figure out what was done? Specifically, what will users see on the page of a dataset that has no license or custom terms?

@jggautier
Copy link
Contributor Author

Just following up now that I'm able to see what was done in the pull request at #10614, which @landreev applied to Harvard Dataverse today when it was updated to v6.4.

Version 2 of the dataset at https://doi.org/10.7910/DVN/0SZMZQ has no license and no custom terms. Here's what folks see on the dataset page:

Screenshot 2024-10-15 at 10 31 57 AM

@jggautier
Copy link
Contributor Author

jggautier commented Oct 17, 2024

Since Harvard Dataverse was updated to v6.4, I found published datasets that have no "pre-defined" license and nothing entered in the "Terms of Use" fields (called "custom terms" sometimes), but that appear to be indexed as having "Custom Terms".

Some of these are in the collection at https://dataverse.harvard.edu/dataverse/MIT-PSFC, including the dataset at https://doi.org/10.7910/DVN/5YY6PE. Some other datasets are at https://doi.org/10.7910/DVN/RFT3ME, https://doi.org/10.7910/DVN/8ACDTT, https://doi.org/10.7910/DVN/FMBUZB, and https://doi.org/10.7910/DVN/IW4V4Y.

All of the datasets I've found so far have "Custom Dataset Terms — the following Custom Dataset Terms have been defined for this dataset." in their "License/Data Use Agreement" fields in the Terms tab:

Screenshot 2024-10-17 at 1 44 17 PM

Just for more context, I found these datasets when I was updating and spot checking info (in a Google Sheet) I've been collecting to help evaluate how depositors have been using Harvard Dataverse to describe the terms of their datasets.

@jggautier jggautier reopened this Oct 17, 2024
@qqmyers
Copy link
Member

qqmyers commented Oct 17, 2024

FWIW: Although I can't see the database, from the display and ORE export it looks like these datasets have no license or terms of use which is not supposed to be allowed. All of them were supposed to have been changed to have TofU that say "This dataset is made available without information on how it can be used. You should communicate with the Contact(s) specified before use." which is now handled by the #10614 code. If these were just missed, a query like the one below could be used to update them so #10614 would apply to them. If there's still a way (post v5.10) that datasets without a license or TofU are getting created, it would be good to find/close that hole.

UPDATE termsofuseandaccess
        SET termsofuse='This dataset is made available without information on how it can be used. You should communicate with the Contact(s) specified before use.'
        WHERE license = 'NONE'
          AND license_id IS NULL
          AND termsofuse IS null
          AND confidentialitydeclaration IS null
          AND specialpermissions IS null
          AND restrictions IS null
          AND citationrequirements IS null
          AND depositorrequirements IS null
          AND conditions IS null
          AND disclaimer IS null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Terms & Licensing Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants