Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move database configuration into application #7418

Closed
poikilotherm opened this issue Nov 17, 2020 · 0 comments · Fixed by #7422 or #7459
Closed

Move database configuration into application #7418

poikilotherm opened this issue Nov 17, 2020 · 0 comments · Fixed by #7422 or #7459
Assignees
@poikilotherm
Labels
Feature: Admin Guide Feature: Installation Guide Feature: Installer Type: Feature a feature request User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Milestone
5.3

Comments

@poikilotherm
Copy link
Contributor

Currently, the database connection is handled on the application server level.

As outlined in #6819 and #7048, this isn't necessary due to Java EE 7 @DataSourceDefinition.
Using MicroProfile Config API #7000, it is a piece of cake to configure.

Let's go for this. Requires #6819 and #7417 to be merged first.
@poikilotherm poikilotherm added Type: Feature a feature request Feature: Installer Feature: Installation Guide Feature: Admin Guide User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh labels Nov 17, 2020
@poikilotherm poikilotherm added this to the 5.3 milestone Nov 17, 2020
@poikilotherm poikilotherm self-assigned this Nov 17, 2020
This was referenced Nov 17, 2020
Merged
Closed
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 18, 2020
@poikilotherm
Provide @DataSourceDefinition for app-level DB config. IQSS#7418
9dfe7b8 
The JNDI names have been changed to be conform with Java EE 7.
See https://github.com/javaee-samples/javaee7-samples/tree/master/jpa/datasourcedefinition-applicationxml-pu
and others for working examples. (Staying with the old name was not successfull.)
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 18, 2020
@poikilotherm
Make the DataSourceDefinition configureable using MicroProfile Config…
b92e465 
… variables in annotation options. IQSS#7418 IQSS#7000
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 18, 2020
@poikilotherm
Add defaults for the database connection using a MicroProfile Config …
3c92120 
…file on classpath. IQSS#7418 IQSS#7000
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 18, 2020
@poikilotherm
Remove stale persistence unit from persistence.xml. IQSS#7418
d05cbaf
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 18, 2020
@poikilotherm
Refactor as-setup.sh installer to use the MPCONFIG based database con…
19c5e98 
…nection configuration. IQSS#7418
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 18, 2020
@poikilotherm
Add docs about the new MPCONFIG based database properties to config d…
b646831 
…oc. IQSS#7418
This was referenced Nov 18, 2020
Merged
Closed
Closed
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Nov 24, 2020
@pdurbin
Merge branch 'develop' into 7418-datasourcedefinition IQSS#7418
813e0fb
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Nov 25, 2020
@pdurbin
fix 'Error in "code-block" directive' IQSS#7418
aa1cc0f
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Nov 25, 2020
@pdurbin
tweaks, remove mention of microprofile-config.properties IQSS#7418
cb4d308 
src/main/resources/META-INF/microprofile-config.properties is important
for developers to know about but sysadmins following the installation
guide need not concern themselves with it.

Other tweaks in this commit are cosmetic. I de-emphasized the
environment variables by putting them in the bottom.
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Dec 1, 2020
@pdurbin
PGXADataSource breaks ingest, use PGPoolingDataSource IQSS#7418
06dbef1
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 2, 2020
@poikilotherm
Remove doubled property usage on DataSourceDefinition following Java …
2d0dc6e 
…EE spec on it. IQSS#7418
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 2, 2020
@poikilotherm
Switch to a javax.sql.ConnectionPoolDataSource class for DataSourceDe…
1c0959b 
…finition plus add some more inline docs. IQSS#7418
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 2, 2020
@poikilotherm
Add more comments about pool sizing and reduce JDBC pool to max 100 c…
ea0cf29 
…onnections. IQSS#7418
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 2, 2020
@poikilotherm
Enable special JDBC connection pooling properties for debugging and m…
a41e177 
…onitoring via MPCONFIG. IQSS#7418
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 2, 2020
@poikilotherm
Make pool resize configurable. IQSS#7418
1a921f6
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 2, 2020
@poikilotherm
Reverting the addition of JDBC pooling settings, configurable via MPC…
83ea82f 
…ONFIG. IQSS#7418

Due to payara/Payara#5024 this is currently not possible. Needs to be addressed
in a later enhancement when Payara provides a solution.
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Dec 3, 2020
@pdurbin
tweak javadoc, default MP config properties IQSS#7418
c583909 
- Show a simple properties example that's easily verifiable by inspecting
server.log (JDBC call debugging).
- Remove MPCONFIG examples that don't work yet (depends on work in
Payara).
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Dec 3, 2020
@pdurbin
format with Netbeans IQSS#7418
f98c164
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Dec 3, 2020
@pdurbin
Merge branch 'develop' into 7418-datasourcedefinition IQSS#7418
9168ad1
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Dec 3, 2020
@pdurbin
mention new JVM options in release notes IQSS#7418
d7f3da1
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Dec 3, 2020
@pdurbin
note that some settings have moved to code IQSS#7418
7e3498e
pdurbin added a commit that referenced this issue Dec 4, 2020
@pdurbin
db_password_alias changed to dataverse.db.password #7418 #7422
5ee7338 
This rename happened in pull request #7422
@pdurbin pdurbin mentioned this issue Dec 4, 2020
Merged
kcondon added a commit that referenced this issue Dec 7, 2020
@kcondon
Merge pull request #7459 from IQSS/7418-db-pw-alias
0511c8a 
db_password_alias changed to dataverse.db.password #7418 #7422
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Remove POSTGRES vars from default.config, no longer necessary. IQSS#7418
37fafcb
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Container init script: remove jHove symlink (see Dockerfile), remove …
f4368fe 
…JMS and JDBC handling due to IQSS#7418 and IQSS#7423
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Jun 11, 2021
@poikilotherm
Remove POSTGRES vars from default.config, no longer necessary. IQSS#7418
d90a3bf
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Jun 11, 2021
@poikilotherm
Container init script: remove jHove symlink (see Dockerfile), remove …
f73b3b3 
…JMS and JDBC handling due to IQSS#7418 and IQSS#7423
@poikilotherm poikilotherm mentioned this issue Jun 24, 2021
Open
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Aug 23, 2021
@poikilotherm
Remove POSTGRES vars from default.config, no longer necessary. IQSS#7418
4502a48
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Aug 23, 2021
@poikilotherm
Container init script: remove jHove symlink (see Dockerfile), remove …
2bb3da8 
…JMS and JDBC handling due to IQSS#7418 and IQSS#7423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poikilotherm poikilotherm

Labels
Feature: Admin Guide Feature: Installation Guide Feature: Installer Type: Feature a feature request User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
None yet
Milestone
5.3
1 participant
@poikilotherm