Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation doesn't explicitly state that counter-processor doesn't collect sub-dataverses #7206

Open
jmjamison opened this issue Aug 18, 2020 · 6 comments
Labels
Feature: Admin Guide Feature: Metrics + Reports Type: Bug a defect User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh

Comments

@jmjamison
Copy link
Contributor

This is minor but would help to add to documentation (up to 4.20).

The documentation for counter-processor probably should state that as-is it doesn't collect sub-dataverses or file-level DOIs. I was directed to a script (https://github.com/IQSS/dataverse/pull/6785/files) that takes care of this but I'm not sure how public that is.

@qqmyers
Copy link
Member

qqmyers commented Aug 18, 2020

@jmjamison - the counter_weekly.sh script is only involved with getting citations from DataCite to Dataverse. The counter_daily.sh script is the only one that is involved in processing the MDC logs and getting the counts for views and downloads back to Dataverse and to DataCite.

FWIW: Now that you raise the issue of making clearer documentation, I think part of that could be to rename those scripts since both are MDC related but the weekly one has no connection with counter-processor at all.

@qqmyers qqmyers mentioned this issue Aug 18, 2020
@jmjamison
Copy link
Contributor Author

True but that's the only way I could add the stats from file level DOIs to the next level up dataset page.

@qqmyers
Copy link
Member

qqmyers commented Aug 18, 2020

Hmm - there really is nothing in the weekly script that could do that (and the api/admin/makeDataCount/:persistentId/updateCitationsForDataset call it makes to Dataverse doesn't touch any of the information/db tables related to counts/downloads).

Is it possible that something you did in setting up the weekly script fixed a problem with the daily script running? I could imagine things related to directories/permissions, permissions on the scripts themselves, the user running the cron jobs, whether the cron job can find curl, etc. that could affect both scripts. It's definitely possible that some requirement in that part of the setup isn't documented and should be.

@jmjamison
Copy link
Contributor Author

I probably wasn't accurate. The weekly script seemed to add file downloads to the dataset page downloads. After reading through the script a few times I realize that doesn't do anything for citations. I'm still trying to get the citation part working. After that I don't think I can do anything about file level citations.

@qqmyers
Copy link
Member

qqmyers commented Aug 18, 2020

Perhaps we're talking about different scripts then - the counter_daily.sh script, also in #6785, is definitely required to see file download counts as MDC downloads on the dataset page.

@jmjamison
Copy link
Contributor Author

jmjamison commented Aug 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Admin Guide Feature: Metrics + Reports Type: Bug a defect User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
None yet
Development

No branches or pull requests

4 participants