Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a researcher, when I replace a file, I want the file metadata of the replaced file to be used for the new file, so that I don't have to re-enter the file metadata #4380

Closed
dliburd opened this issue Dec 13, 2017 · 4 comments · Fixed by #7337
Assignees
Labels
Feature: Metadata User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@dliburd
Copy link
Contributor

dliburd commented Dec 13, 2017

I've come across two a possible issues with file replace
I used the "file replace" feature to replace a file with a new one with the same name. The new file was given the "-1" suffix once it is uploaded. Logically this file will be replacing the previous file and won't coexist with the original file, so the "-1" suffix isn't necessary.

When replacing a file the original file's metadata doesn't not carryover. I would expect the files description and tags to be the same as the original file since I'm replacing the file. There is also no warning that the metadata and tags will have to be reentered.

I feel like if I have to reenter the metadata and manually rename the replaced file, I would have just deleted the original file and uploaded the new file.

@TaniaSchlatter TaniaSchlatter added the UX & UI: Design This issue needs input on the design of the UI and from the product owner label Dec 13, 2017
@dliburd dliburd changed the title FIle Replace not working as expected File Replace not working as expected Jan 12, 2018
@djbrooke djbrooke self-assigned this Jan 25, 2018
@adam3smith
Copy link
Contributor

@pdurbin pointed me here so I just wanted to add our user story for keeping the metadata during replace:
When we curate, we often want to keep user-supplied file-level metadata like descriptions, but may need to replace the file. Replace would be ideal for this, but of course only if it actually keeps the metadata.

@qqmyers
Copy link
Member

qqmyers commented Apr 17, 2018

FWIW - when we discussed this issue in SEAD, the concern that metadata is about file contents and context, which change when a file is replaced/versioned/copied, made it hard to see how any default would work in all cases, so we planned to ask the user, e.g. to check/uncheck/edit each entry as part of the versioning/replacement/copy workflow. We also considered whether copying the metadata and just warning the user to inspect/edit it as needed would be enough. (We have not yet implemented that but we've had similar feedback that dropping metadata is seen as causing extra work... )

dlmurphy added a commit that referenced this issue Apr 17, 2018
Added details about draft datasets and metadata to build appropriate
expectations and resolve user confusion.
@dlmurphy
Copy link
Contributor

Whether or not we change the functionality of the file replace feature in the future, for now I've at least updated our documentation to make it clear that file replace can not be carried out on a draft dataset, and that when replacing a file, its original metadata will not be carried over.

@pdurbin pdurbin added the User Role: Depositor Creates datasets, uploads data, etc. label Jul 13, 2018
@jggautier jggautier changed the title File Replace not working as expected As a researcher, when I replace a file, I want the file metadata of the replaced file to be used for the new file, so that I don't have to re-enter the file metadata Aug 23, 2018
@jggautier
Copy link
Contributor

The first issue, about Dataverse adding a "-1" suffix to the name of a file that is replacing another file with the same name, has been resolved. So I removed it and renamed this issue to focus on the existing behavior (as of Dataverse 4.9.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Metadata User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants