Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administration Changes to Support rsync #3347

Closed
djbrooke opened this issue Sep 13, 2016 · 6 comments
Closed

Administration Changes to Support rsync #3347

djbrooke opened this issue Sep 13, 2016 · 6 comments

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Sep 13, 2016

We'll need to make changes at the Installation and the dataverse level to support the new options available for rsync. Two that were discussed were:

  • Administrators able to define the file transfers/uploads available (dropbox, rsync, UI)
  • Setting the Data Capture Module (Data Capture Module (rsync support) #3145) URL in the installation configuration settings
@pdurbin
Copy link
Member

pdurbin commented Sep 13, 2016

During the 2016-09-08 SBGrid Sprint Planning meeting ( https://docs.google.com/document/d/1wWSdKUOGA1L7UqFsgF3aOs8_9uyjnVpsPAxk7FObOOI/edit ) this issue was given an effort level of "3" because code has already been written.

We're using :DataCaptureModuleUrl as the setting key in the database in the standard way.

With regard to administrators being able to define the file transfers available we have defined an enum called FileUploadMechanism on the Dataset entity: https://github.com/bmckinney/dataverse-canonical/blob/b280c34fcc231b41cf9e801aff992e3858c17775/src/main/java/edu/harvard/iq/dataverse/Dataset.java#L43 . I'm fine with the approach (I added it) and I think @bmckinney and @pameyer are fine with it as well but during the meeting I got the impression that @scolapasta wanted to weigh in on the design before we commit to this approach so I'm assigning this issue to him, me, and Bill to discuss.

@pdurbin
Copy link
Member

pdurbin commented Sep 15, 2016

@bmckinney @djbrooke and I discussed this and we moved it to "Ready" at https://waffle.io/IQSS/dataverse

@bmckinney and I are fine with the approach so I believe the next step is to make a pull request based on the code mentioned above.

@pdurbin pdurbin added in progress and removed ready labels Sep 20, 2016
@pdurbin pdurbin assigned pdurbin and unassigned pdurbin, bmckinney and scolapasta Sep 20, 2016
@pdurbin pdurbin removed their assignment Sep 26, 2016
@pdurbin pdurbin added the SBGrid label Oct 7, 2016
@pdurbin pdurbin removed the ready label Nov 3, 2016
@djbrooke
Copy link
Contributor Author

djbrooke commented May 2, 2017

@pdurbin @pameyer

@pdurbin
Copy link
Member

pdurbin commented May 2, 2017

@djbrooke this issue is one of eight created last September in our attempt to break #3145 into smaller chunks: #3145 (comment)

Yes, the code mentioned above is helpful, especially #3724. There's still an open question of if @scolapasta wants to weight in on the approach before we commit to it, as mentioned at #3347 (comment) . In #3724 this is described as "Binary configuration items (on/off switch), or lists (native/http,dcm/rsync+ssh, etc)? Additional implementation complexity and/or performance of lists vs binary hasn't been evaluated." A decision still needs to be made.

For now I'll link to this issue from #3724.

@pdurbin
Copy link
Member

pdurbin commented Jun 25, 2017

I'm closing this because #3724 is done and #3942 is in the works.

@pdurbin pdurbin closed this as completed Jun 25, 2017
@pdurbin
Copy link
Member

pdurbin commented Jun 25, 2017

#3348 is still open as well so we can circle back to anything written back above, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants