Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Dataverse users, record (1) date created, (2) last login, and (3) lastApiUse #3246

Closed
raprasad opened this issue Aug 8, 2016 · 5 comments
Closed

For Dataverse users, record (1) date created, (2) last login, and (3) lastApiUse #3246

raprasad opened this issue Aug 8, 2016 · 5 comments
Assignees
@kcondon
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Feature: Account & User Info Type: Feature a feature request
Milestone
4.7.1 - Dashboard

Comments

@raprasad
Copy link
Contributor

raprasad commented Aug 8, 2016 •
edited by djbrooke
Loading

Add the following timestamp columns to the authenticated user table:

  • authenticateduser.created
  • authenticateduser.last_login (this may already be covered by 'modificationtime')
  • authenticateduser.last_confirmed (possible - @scolapasta's discretion)

To supply basic metrics to stakeholders and dev. team including:

  • how many users are added to the system during specific time periods (e.g. users added per month)
  • how many people log in to the system (e.g. each month, each day, etc.)
  • how many accounts are "inactive" -- e.g. haven't logged in for extended periods of time
  • when does activity spike for logged in users, etc
@pdurbin
Copy link
Member

pdurbin commented Aug 15, 2016

Related: #2470

@pdurbin pdurbin mentioned this issue Aug 15, 2016
Closed
@djbrooke djbrooke removed the ready label Aug 31, 2016
@bsilverstein95 bsilverstein95 self-assigned this Jun 14, 2017
@raprasad raprasad self-assigned this Jun 14, 2017
raprasad added a commit that referenced this issue Jun 14, 2017
@raprasad
part of #3246 -- MUST RUN db update
26b244b
@raprasad
Copy link
Contributor Author

  • do we want to record lastlogin info for API calls?
    • e.g. file: AbstractAPIBean.java method: findAuthenticatedUserOrDie

raprasad added a commit that referenced this issue Jun 14, 2017
@raprasad
#3246 - for last login
ce157c4
raprasad added a commit that referenced this issue Jun 19, 2017
@raprasad
updates for user creation time. #3246
6d76055
raprasad added a commit that referenced this issue Jun 19, 2017
@raprasad
#3246 all lastLogin to be null; add lastApiUse column
79a9c53
raprasad added a commit that referenced this issue Jun 20, 2017
@raprasad
removed cruft. unused files #3246
54e0602
bsilverstein95 added a commit that referenced this issue Jun 20, 2017
@bsilverstein95
#3246 added javadoc in AuthenticatedUserTest.java
5eb199a
@bsilverstein95 bsilverstein95 mentioned this issue Jun 20, 2017
Merged
5 tasks
@raprasad raprasad removed their assignment Jun 20, 2017
@pdurbin pdurbin assigned bsilverstein95 and unassigned pdurbin and scolapasta Jun 21, 2017
pdurbin referenced this issue Jun 22, 2017
@pdurbin
Shib: pick first email if multiple asserted #2512 #2939
ffd1d6e 
- Put email addresses throught the same "find single value" logic
  originally developed in #1608 for multiple first and last names.
- Add `@ValidateEmail` to the "email" field on AuthenticatedUser to
  match BuiltinUser.
- Add null check added to EmailValidator to make it testable.
- Add `INVALID_EMAIL` and `MISSING_REQUIRED_ATTR` modes for Shib testing
  in dev.
- Remove red warning when TestShib doesn't provide "mail" attribute.
- Catch authSvc.createAuthenticatedUser exceptions and handle errors
  better.
- Reformat code (getPrettyFacesHomePageString seems ok).
bsilverstein95 added a commit that referenced this issue Jun 23, 2017
@bsilverstein95
Added integration tests/adjusted new column names/first round of code…
4142fec 
… cleanup #3246
@pdurbin
Copy link
Member

pdurbin commented Jun 25, 2017

@bsilverstein95 is the code your writing a fix for #2470? Should we close that issue as a duplicate of this one?

@pdurbin
Copy link
Member

pdurbin commented Jun 25, 2017

@bsilverstein95 same question for issue #2485.

@pdurbin pdurbin mentioned this issue Jun 25, 2017
Closed
@bsilverstein95
Copy link
Contributor

@pdurbin For #2470 yes, my code for this issue covers it with addition of authenticateduser.createdtime; as for #2485 (which is already closed now!) it effectively covers that as well except I haven't modified the builtinuser table.

bsilverstein95 added a commit that referenced this issue Jun 26, 2017
@bsilverstein95
Merge remote-tracking branch 'origin/develop' into 3246-user-login #3246
6f3c532
@djbrooke djbrooke assigned pdurbin and raprasad and unassigned bsilverstein95 and pdurbin Jun 26, 2017
bsilverstein95 added a commit that referenced this issue Jun 26, 2017
@bsilverstein95
Remove modificationtime column from authenticateduser table #3246
20df0e6
raprasad added a commit that referenced this issue Jun 26, 2017
@raprasad
small change #3246
33f8fe4
@raprasad raprasad removed their assignment Jun 26, 2017
@kcondon kcondon self-assigned this Jun 26, 2017
bsilverstein95 added a commit that referenced this issue Jun 27, 2017
@bsilverstein95
Fixed failing unit test for #3246
5aaeb2e
kcondon added a commit that referenced this issue Jun 27, 2017
@kcondon
Merge pull request #3931 from IQSS/3246-user-login
982b9db 
#3246: added last login/creation time/last API use for authenticateduser
@kcondon kcondon closed this as completed Jun 27, 2017
@djbrooke djbrooke added this to the 4.7.1 - Dashboard milestone Jun 28, 2017
@pdurbin pdurbin mentioned this issue Aug 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Feature: Account & User Info Type: Feature a feature request
Projects
None yet
Milestone
4.7.1 - Dashboard
Development

No branches or pull requests
6 participants
@pdurbin @raprasad @scolapasta @kcondon @djbrooke @bsilverstein95