Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a series of changes to the
edu.harvard.iq.dataverse_hub
project, focusing on code refactoring, the addition of unit tests, and the renaming of test files for better organization. The most important changes are summarized below:Code Refactoring:
AccessToken
fromtoken_id
totokenId
anduser_id
touserId
, and added getter and setter methods, along withtoString
andequals
methods. (src/main/java/edu/harvard/iq/dataverse_hub/model/AccessToken.java
)AccessTokenRepo
to use the new field names in the query. (src/main/java/edu/harvard/iq/dataverse_hub/repository/AccessTokenRepo.java
)isGdccMember
method fromInstallation.java
and replaced it withgetGdccMember
. (src/main/java/edu/harvard/iq/dataverse_hub/model/Installation.java
)findByDVHubId
fromInstallationService.java
. (src/main/java/edu/harvard/iq/dataverse_hub/service/InstallationService.java
)UserService.validateRequest
method to handle null requests. (src/main/java/edu/harvard/iq/dataverse_hub/service/UserService.java
)Addition of Unit Tests:
ServerMessageResponse
,ErrorResponseController
,InstallationController
,OpenAPIController
,AccessToken
,InstallationDao
,ScheduledJob
,VersionInfoDao
,TokenAuthFilter
, andInstallationService
. (Multiple files)Renaming of Test Files:
InstallationGitImporterTests.java
toscheduled/InstallationGitImporterTests.java
VersionDVInstallationCheckTests.java
toscheduled/VersionDVInstallationCheckTests.java
RestHelperServiceTests.java
toservice/RestHelperServiceTests.java
ScheduledJobServiceTests.java
toservice/ScheduledJobServiceTests.java