Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check/Format correct files with Prettier #523

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Oct 16, 2024

What this PR does / why we need it:

It fixes which files prettier was formatting/checking or not.
There are a lot of modified files but it is only because we are now formatting correctly with prettier html, tsx ts and scss files.

Which issue(s) this PR closes:

Special notes for your reviewer:

This issue should also close issue Fix Stylelint configuration .

Stylelint is not functioning as expected. It should enforce rules such as 'declaration-colon-space-after' to correct instances like padding:15px; to padding: 15px;, but it appears to be malfunctioning.

'declaration-colon-space-after' is now deprecated (see stylelint docs) so as long as you are using prettier with autosave it should format it correctly and if not we can always use the npm run lint:fix command mentioned in the Linting section from the DEVELOPER_GUIDE.

Suggestions on how to test this:

What can be done is to incorrectly indent a .tsx file and a .scss file and then run the command npm run lint:prettier and validate that these two files are mentioned with errors.
Then run npm run lint:fix to validate that this command fixes the indentation errors.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

No

@g-saracca g-saracca added bug Something isn't working FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 GREI Re-arch GREI re-architecture-related SPA.Q4.10 Resolve TODOs and tech debt SPA labels Oct 16, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.28% (+0.09%) from 97.186%
when pulling 3d040a6 on feat/373-prettier-check
into 72348db on develop.

@g-saracca g-saracca changed the title Feat/373 Prettier check correct files Check correct files with Prettier Oct 16, 2024
@g-saracca g-saracca changed the title Check correct files with Prettier Check/Format correct files with Prettier Oct 16, 2024
@ChengShi-1 ChengShi-1 self-requested a review October 18, 2024 13:26
@ChengShi-1 ChengShi-1 self-assigned this Oct 18, 2024
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@ChengShi-1 ChengShi-1 removed their assignment Oct 18, 2024
@ofahimIQSS ofahimIQSS self-assigned this Oct 18, 2024
@ofahimIQSS
Copy link
Contributor

Tested - no issues found. Merging PR

Testing of 523.docx

@ofahimIQSS ofahimIQSS merged commit 31c2d49 into develop Oct 21, 2024
15 of 18 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/373-prettier-check branch October 21, 2024 13:41
@ofahimIQSS ofahimIQSS removed their assignment Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q4.10 Resolve TODOs and tech debt SPA
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Prettier check correct files
4 participants