-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check/Format correct files with Prettier #523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
bug
Something isn't working
FY25 Sprint 8
FY25 Sprint 8 (2024-10-09 - 2024-10-23)
Size: 3
A percentage of a sprint. 2.1 hours.
Original size: 3
GREI Re-arch
GREI re-architecture-related
SPA.Q4.10
Resolve TODOs and tech debt
SPA
labels
Oct 16, 2024
g-saracca
changed the title
Feat/373 Prettier check correct files
Check correct files with Prettier
Oct 16, 2024
g-saracca
changed the title
Check correct files with Prettier
Check/Format correct files with Prettier
Oct 16, 2024
ChengShi-1
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Tested - no issues found. Merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
FY25 Sprint 8
FY25 Sprint 8 (2024-10-09 - 2024-10-23)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q4.10
Resolve TODOs and tech debt
SPA
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It fixes which files prettier was formatting/checking or not.
There are a lot of modified files but it is only because we are now formatting correctly with prettier html, tsx ts and scss files.
Which issue(s) this PR closes:
Special notes for your reviewer:
This issue should also close issue Fix Stylelint configuration .
'declaration-colon-space-after'
is now deprecated (see stylelint docs) so as long as you are using prettier with autosave it should format it correctly and if not we can always use thenpm run lint:fix
command mentioned in the Linting section from the DEVELOPER_GUIDE.Suggestions on how to test this:
What can be done is to incorrectly indent a
.tsx
file and a.scss
file and then run the commandnpm run lint:prettier
and validate that these two files are mentioned with errors.Then run
npm run lint:fix
to validate that this command fixes the indentation errors.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
No