-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransferList component #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! The only thing I noticed is that if you check items on one side, then select them all to be moved, the checks are still there on the other side, is that intended behavior?
Screen.Recording.2024-08-14.at.4.23.06.PM.mov
@ekraffmiller Yes, that is indeed the expected behaviour. |
Ok, I hadn't thought of that, but it makes sense! thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
@GermanSaracca Can you resolve merge conflicts? And I will merge after that. Thanks! |
@GPortas done! |
What this PR does / why we need it:
Adds new TransferList component to the Design System.
I have used packages from the dnd-kit library to achieve the sorting through drag and drop.
Which issue(s) this PR closes:
Closes #449
Special notes for your reviewer:
Suggestions on how to test this:
Check the documentation of the component on Storybook.
Check and try the different stories and see the logs on the dev tools console.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Screen.Recording.2024-08-13.at.14.39.18.mov
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A