Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransferList component #458

Merged
merged 19 commits into from
Aug 19, 2024
Merged

TransferList component #458

merged 19 commits into from
Aug 19, 2024

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Aug 13, 2024

What this PR does / why we need it:
Adds new TransferList component to the Design System.
I have used packages from the dnd-kit library to achieve the sorting through drag and drop.

Which issue(s) this PR closes:

Closes #449

Special notes for your reviewer:

Suggestions on how to test this:
Check the documentation of the component on Storybook.
Check and try the different stories and see the logs on the dev tools console.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Screen.Recording.2024-08-13.at.14.39.18.mov

Is there a release notes update needed for this change?:
N/A

Additional documentation:
N/A

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. D: Design System Deliverable: Design System GREI Re-arch GREI re-architecture-related SPA: New Collection Page FY25 Sprint 3 FY25 Sprint 3 labels Aug 13, 2024
@coveralls
Copy link

coveralls commented Aug 13, 2024

Coverage Status

coverage: 97.939% (+0.04%) from 97.9%
when pulling 9e44a99 on feat/449-transfer-list-component
into 7bc5d41 on develop.

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The only thing I noticed is that if you check items on one side, then select them all to be moved, the checks are still there on the other side, is that intended behavior?

Screen.Recording.2024-08-14.at.4.23.06.PM.mov

@g-saracca
Copy link
Contributor Author

@ekraffmiller Yes, that is indeed the expected behaviour.
I can change it, but I thought about leaving it since normally if you check the checboxes it is because you don't want to transfer them all, so if you unintentionally transfer them all, you can transfer them all back to the left and your original selection will be kept so that you can only transfer the selected ones again if you want to.

@g-saracca g-saracca removed their assignment Aug 15, 2024
@ekraffmiller
Copy link
Contributor

@ekraffmiller Yes, that is indeed the expected behaviour. I can change it, but I thought about leaving it since normally if you check the checboxes it is because you don't want to transfer them all, so if you unintentionally transfer them all, you can transfer them all back to the left and your original selection will be kept so that you can only transfer the selected ones again if you want to.

Ok, I hadn't thought of that, but it makes sense! thanks

ekraffmiller
ekraffmiller previously approved these changes Aug 15, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ekraffmiller ekraffmiller removed their assignment Aug 15, 2024
@GPortas GPortas self-assigned this Aug 19, 2024
GPortas
GPortas previously approved these changes Aug 19, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@GPortas
Copy link
Contributor

GPortas commented Aug 19, 2024

@GermanSaracca Can you resolve merge conflicts? And I will merge after that. Thanks!

@g-saracca g-saracca dismissed stale reviews from GPortas and ekraffmiller via 9e44a99 August 19, 2024 14:58
@g-saracca
Copy link
Contributor Author

@GPortas done!

@g-saracca g-saracca removed their assignment Aug 19, 2024
@GPortas GPortas merged commit f66b503 into develop Aug 19, 2024
10 of 14 checks passed
@g-saracca g-saracca deleted the feat/449-transfer-list-component branch August 21, 2024 11:35
@GPortas GPortas added SPA.Q3.4 Create Collection page (Full version) Original size: 3 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: Design System Deliverable: Design System FY25 Sprint 3 FY25 Sprint 3 GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: New Collection Page SPA.Q3.4 Create Collection page (Full version)
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

TransferList Component
4 participants