Metadata fields section on create collection page #451
Conversation
g-saracca
added
UI
src/metadata-block-info/infrastructure/repositories/MetadataBlockInfoJSDataverseRepository.ts
Outdated
Show resolved
Hide resolved
| astrophysicsBlock: ReducedMetadataBlockInfo | ||
| biomedicalBlock: ReducedMetadataBlockInfo | ||
| journalBlock: ReducedMetadataBlockInfo | ||
| } { |
There was a problem hiding this comment.
If the list of metadataBlocks is retrieved from the API in the future, will this hard-coded list have to be converted to something dynamic?
There was a problem hiding this comment.
Exactly, all parts of the code where I explicitly define this 6 metadata blocks will be dynamic.
| } | ||
| export type CollectionFormMetadataBlock = Exclude< | ||
| MetadataBlockName, | ||
| MetadataBlockName.CODE_META | MetadataBlockName.COMPUTATIONAL_WORKFLOW |
There was a problem hiding this comment.
Why do we have these names in MetadataBlockName without using them? Will they be used in the future?
There was a problem hiding this comment.
This is the same thing about dynamic or not dynamic metadata blocks, will change also later, this is to narrow down MetadataBlockName to all enums except those two.
|
Also, there is an error in the e2e test, in CollectionJSDataverseRepository.spec.ts, I think it needs to be updated to match the new Collection model: |
|
Hi @ekraffmiller, I make the requested changes and fix the e2e test 👍🏼 |
|
Update to latest version of js-dataverse and change registry back to docker.io. |
What this PR does / why we need it:
Adds the Metadata Fields section to the create collection page.
Which issue(s) this PR closes:
Closes #444
Special notes for your reviewer:
Suggestions on how to test this:
Create a Collection from both the header ( from there will always create a collection inside Root).
Change different input levels configurations and save the collection.
Go to that collection and create a dataset from there, check fields that has been set as required, optional or hidden.
Also navigate to that created collection and check that all the input levels are configured by default as the parent collection.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
metadata-fields-section-recording.mov
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A