321 default dataset version #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
GREI Re-arch
g-saracca
reviewed
Jul 23, 2024
src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts
Outdated
Show resolved
Hide resolved
src/sections/shared/form/DatasetMetadataForm/useSubmitDataset.ts
Outdated
Show resolved
Hide resolved
|
Thanks @GermanSaracca I made the suggested changes - the component test is failing in the last run only because I had to re-run it, and the coveralls script failed the second time since the coverage report had been created on the first run. I'm not sure why the component tests had to be re-run, it seems like maybe a failure to get the stock images for the metadata test? |
What do you mean by stock images ? I couldn't find that part of the code, are we using an external images library in some test? Approving 🚀 , we can discuss about those test for another iteration I believe 👍🏼 |
g-saracca
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes the default dataset version requested from :latest to :latest-published. This is needed to match the behavior of the JSF. In the JSF, If a dataset has a draft version and a published version, View Dataset page shows the published version by default (when there isn't a version search param in the url).
Which issue(s) this PR closes:
Closes #321
Special notes for your reviewer:
Now that the default version is :latest-published, in order to view the draft version of a dataset, you need to add 'version=DRAFT' to the view dataset url. (The draft version used to be displayed by default when the user has permission to view it).
Suggestions on how to test this:
Create a dataset that has a published version and a draft version. Test that the version displayed in the View Dataset page is the published version, when no version search param is used.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
Additional documentation: