Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/429 dataset files scroll selection #430

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:
Fix file selection on files table with infinite scrolling from a dataset

Which issue(s) this PR closes:

Closes #429

Special notes for your reviewer:
N/A

Suggestions on how to test this:
See unexpected behavior on #429 bug description.

  1. Create a Dataset with +40 files.
  2. Navigate to that Dataset in the SPA.
  3. Select first 10 and then click Select All button, then scroll to the bottom several times to load the rest of the files.
  4. File Selection should persist.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A

Is there a release notes update needed for this change?:
N/A

Additional documentation:
N/A

@g-saracca g-saracca added bug Something isn't working Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset page (View) GREI Re-arch GREI re-architecture-related labels Jul 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.589% (+0.008%) from 97.581%
when pulling de94cb5 on fix/429-dataset-files-scroll-selection
into 107aaca on develop.

@ekraffmiller ekraffmiller self-assigned this Jul 23, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Works great :)

@ekraffmiller ekraffmiller removed their assignment Jul 24, 2024
@GPortas GPortas self-assigned this Jul 25, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

Untitled.mov

@GPortas GPortas merged commit 0d9124c into develop Jul 31, 2024
17 of 20 checks passed
@GPortas GPortas deleted the fix/429-dataset-files-scroll-selection branch July 31, 2024 13:35
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 3 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset page (View) SPA.Q3 Not related to any specific Q3 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Dataset File Tab Selection unexpected behavior on Infinite scroll mode
4 participants