-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/355 select multiple component #385
Conversation
… to private members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I don't have any requested changes in the code, but I noticed a behavior in the Story that I think could be improved. When you type in the search to get a subset of items, then click the select all checkbox, it selects all the items in the list, not just what you selected, which seems a little unexpected.
For example:
Screen.Recording.2024-05-02.at.9.10.55.PM.mov
Nice catch ellen! thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm facing the same error that @ekraffmiller initially detected. When I select all items based on a query string, all items without filter are selected. This happens in both stories.
Screen.Recording.2024-05-06.at.10.48.13.mov
Screen.Recording.2024-05-06.at.10.50.54.mov
Hi @GPortas , the initial storybooks links from the PR description are outdated, they have the code before the changes requested by @ekraffmiller. |
…ponent Feature/355 select multiple component
What this PR does / why we need it:
Adds new Select Multiple component to the Design System.
Which issue(s) this PR closes:
Closes #355
Special notes for your reviewer:
Also export some form elements interfaces to solve a ts errors issue when building the design system about FormGroup trying to access private types.
Also add props to existent Select component.
Suggestions on how to test this:
Test the component in storybook.
Check Isolated Select Multiple component in Storybook
Check Select Multiple component within a form in Storybook.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
CHANGELOG in the Design System package has been updated.
Additional documentation:
No.