-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/file upload page boilerplate #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just had a question about how we are going to handle the different Edit Actions, see my comment
Requested changes applied + component test + interface extension of DropdownButtonItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works good!
testfileboilerplate.mov
…plate Feature/file upload page boilerplate
What this PR does / why we need it:
Set up the boilerplate for the file upload page,
Which issue(s) this PR closes:
Special notes for your reviewer:
Breadcrumbs need more work on a separate issue, they work for dvObject hierarchy: collection, dataset, file; but we need to think on how to make it work for actions items like: Root > Dataset > Edit Files
Created issue for this metioned above : #380
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes
Is there a release notes update needed for this change?:
Additional documentation: