Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/file upload page boilerplate #375

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Apr 17, 2024

What this PR does / why we need it:

Set up the boilerplate for the file upload page,

  • Breadcrumbs
  • Navigation (from dataset page "Upload Files" and Edit Dataset > Files (Upload) buttons)
  • Page not found if the dataset is not found

Which issue(s) this PR closes:

Special notes for your reviewer:

Breadcrumbs need more work on a separate issue, they work for dvObject hierarchy: collection, dataset, file; but we need to think on how to make it work for actions items like: Root > Dataset > Edit Files
Created issue for this metioned above : #380

Suggestions on how to test this:

  • Log in and navigate to a dataset, test clicking both buttons mentioned above that take you to the Edit Dataset Files page.
  • Also change some character of the persistent ID query param in the url and reload the page, Not Found page should be shown.
  • Same Not Found page should be shown if going directly to that page without been authenticated.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes

Is there a release notes update needed for this change?:

Additional documentation:

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: File Upload Page labels Apr 17, 2024
@ekraffmiller ekraffmiller self-assigned this Apr 18, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had a question about how we are going to handle the different Edit Actions, see my comment

src/sections/Route.enum.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 97.333% (-0.2%) from 97.495%
when pulling 29a3023 on feature/file-upload-page-boilerplate
into 620e31b on develop.

@g-saracca g-saracca assigned ekraffmiller and unassigned g-saracca Apr 19, 2024
@g-saracca
Copy link
Contributor Author

Requested changes applied + component test + interface extension of DropdownButtonItem

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GPortas GPortas assigned GPortas and unassigned ekraffmiller Apr 23, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good!

testfileboilerplate.mov

@GPortas GPortas merged commit 35f1747 into develop Apr 23, 2024
14 checks passed
@GPortas GPortas deleted the feature/file-upload-page-boilerplate branch April 23, 2024 15:14
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…plate

Feature/file upload page boilerplate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Upload Page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the boilerplate of the file upload page
4 participants