Feature/358 add unpublished label to collections page #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
pm.GREI-d-2.7.1
g-saracca
requested changes
Apr 17, 2024
GPortas
reviewed
Apr 22, 2024
There was a problem hiding this comment.
I just created a test collection and it doesn't show the Unpublished label. It is shown in JSF.
SPA:
JSF:
maybe I'm missing something? @ekraffmiller
|
Oh, nevermind. I see the isReleased value is hardcoded to false. I am going to hardcode it to true and see what happens. @ekraffmiller EDIT: Looks good, approving:
|
GPortas
approved these changes
Apr 22, 2024
GPortas
deleted the
feature/358-add-unpublished-label-to-collections-page
branch
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…el-to-collections-page Feature/358 add unpublished label to collections page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an 'Unpublished' label to the Collections page, if the collection has not been published
Which issue(s) this PR closes:
Special notes for your reviewer:
The flag, isReleased, is not yet available from the javascript library, waiting for this: IQSS/dataverse-client-javascript#139
Suggestions on how to test this:
Look at the UnpublishedCollection Story, which shows the label: http://localhost:6006/?path=/story/sections-collection-page-collectioninfo--unpublished
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
This is what the label looks like in JSF:
Is there a release notes update needed for this change?:
no
Additional documentation: