-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/338 form validation library #368
Merged
g-saracca
merged 30 commits into
feature/sub-branch/dynamic-fields-and-validation
from
feature/338-form-validation-library
Apr 11, 2024
Merged
Feature/338 form validation library #368
g-saracca
merged 30 commits into
feature/sub-branch/dynamic-fields-and-validation
from
feature/338-form-validation-library
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id conflicts with form anidation
…se never seen because of react batching
g-saracca
merged commit Apr 11, 2024
60eeb53
into
feature/sub-branch/dynamic-fields-and-validation
8 of 13 checks passed
g-saracca
added
pm.GREI-d-2.6.1
NIH, yr2, aim6, task1: Test differentially private releases with NIH-funded datasets
pm.GREI-d-2.6.2
NIH, yr2, aim6, task2: Design and implement MVP for DataTags levels
SPA: Create Dataset Form
labels
Apr 11, 2024
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…rary Feature/338 form validation library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pm.GREI-d-2.6.1
NIH, yr2, aim6, task1: Test differentially private releases with NIH-funded datasets
pm.GREI-d-2.6.2
NIH, yr2, aim6, task2: Design and implement MVP for DataTags levels
SPA: Create Dataset Form
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds form validation library (react-hook-form) to the create dataset form in order to create dynamic fields validation
Which issue(s) this PR closes:
Special notes for your reviewer:
This PR points to a sub-branch because before targeting the develop branch it will be combined with the issue #336 which is in this sub-branch and then a final pr with both issues combined will be made to develop. All this to be able to bring up something completely stable to beta environment.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Also I modified at spa level not design system level the styles for the checkbox group, I think if it is successful we could apply it to the design system directly in the future.
This checkbox group that allows to select multiple values is a temporary replacement of the select multiple not yet done.
Examples below: 👇👇
Is there a release notes update needed for this change?:
Additional documentation:
I have refactored some form elements of the design system so that they can forward a react ref and pass it to the input itself. This was necessary so that the form validation library could focus and scroll to the first item encountered with a validation error.