Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/336 dynamically render form fields #357

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Mar 28, 2024

What this PR does / why we need it:

Dynamically displays the form fields to create a Dataset based on backend configuration from the collection to which the dataset to be created would belong.

Which issue(s) this PR closes:

Special notes for your reviewer:

At the moment we are working with mocked data in order to continue working until the issue #135 is ready to be integrated.
This PR points to a sub-branch because before targeting the develop branch it will be combined with the issue #338 which will be created from this sub-branch and then a final pr with both issues combined will be made to develop. All this to be able to bring up something completely stable to beta environment.

Suggestions on how to test this:

Log in, click the create dataset button and the form fields should be displayed successfully.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes.
spa_datasets_create(Desktop 1366)

Is there a release notes update needed for this change?:

Additional documentation:

I have refactor some design system components:

  • Accordion: refactor of props using already existen props from react-bootstrap.
  • AccordionBody: able to receive bsPrefix and as props and extend html props attributes.
  • AccordionHeader: able to receive onClick, bsPrefix and as props and extend html props attributes.
  • AccordionItem: able to receive bsPrefix and as props and extend html props attributes.
  • FormGroup: able to clone children but wrapped through fragments also.
    All tests were ok and add one more test to test the cloning through childrens wrapped in fragments.

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: Create Dataset Form labels Mar 28, 2024
@g-saracca g-saracca merged commit 7fde401 into feature/sub-branch/dynamic-fields-and-validation Apr 1, 2024
7 of 13 checks passed
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…form-fields

Feature/336 dynamically render form fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: Create Dataset Form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant