-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/336 dynamically render form fields #357
Merged
g-saracca
merged 21 commits into
feature/sub-branch/dynamic-fields-and-validation
from
feature/336-dynamically-render-form-fields
Apr 1, 2024
Merged
Feature/336 dynamically render form fields #357
g-saracca
merged 21 commits into
feature/sub-branch/dynamic-fields-and-validation
from
feature/336-dynamically-render-form-fields
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Item html attributes
…d extend accordion html attributs and props
…ions buttons space
… feature/336-dynamically-render-form-fields
g-saracca
added
Size: 3
A percentage of a sprint. 2.1 hours.
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
SPA: Create Dataset Form
labels
Mar 28, 2024
g-saracca
merged commit Apr 1, 2024
7fde401
into
feature/sub-branch/dynamic-fields-and-validation
7 of 13 checks passed
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…form-fields Feature/336 dynamically render form fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Create Dataset Form
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Dynamically displays the form fields to create a Dataset based on backend configuration from the collection to which the dataset to be created would belong.
Which issue(s) this PR closes:
Special notes for your reviewer:
At the moment we are working with mocked data in order to continue working until the issue #135 is ready to be integrated.
This PR points to a sub-branch because before targeting the develop branch it will be combined with the issue #338 which will be created from this sub-branch and then a final pr with both issues combined will be made to develop. All this to be able to bring up something completely stable to beta environment.
Suggestions on how to test this:
Log in, click the create dataset button and the form fields should be displayed successfully.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Is there a release notes update needed for this change?:
Additional documentation:
I have refactor some design system components:
bsPrefix
andas
props and extend html props attributes.onClick
,bsPrefix
andas
props and extend html props attributes.bsPrefix
andas
props and extend html props attributes.All tests were ok and add one more test to test the cloning through childrens wrapped in fragments.