Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

279 - Fix remove loading text #287

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Jan 25, 2024

What this PR does / why we need it:

This PR removes the loading text that appears when accessing the SPA.

image

Which issue(s) this PR closes:

Special notes for your reviewer:

The loading message was a placeholder for the React Suspense fallback. This fallback exists to give some feedback to the user about the page being loaded but it didn't seem to be necessary since we don't have long loading times and there is already a loading indicator when accessing any SPA page

Check the video to see the loading text appearing:
https://github.com/IQSS/dataverse-frontend/assets/17010447/60c11a1e-6ad3-4827-861c-1655a5ebb651

Suggestions on how to test this:

Step 1: Run the development environment

  1. Run npm I
  2. cd packages/design-system && npm run build
  3. cd ../../
  4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
  5. cd dev-env
  6. ./run-env.sh unstable
  7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test Dataset View mode with the implemented changes to download the files

  1. Go to http://localhost:8000/spa
  2. Check that during the loading of the page, no 'loading' text appears at the top left corner of the page.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@coveralls
Copy link

Coverage Status

coverage: 97.822%. remained the same
when pulling b81f0d6 on fix/279-loading-text-appears-when-navigating
into c0516c5 on develop.

@MellyGray MellyGray added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Jan 25, 2024
@MellyGray MellyGray marked this pull request as ready for review January 25, 2024 10:38
@M27Mangan M27Mangan self-requested a review January 29, 2024 19:32
@M27Mangan M27Mangan self-assigned this Jan 29, 2024
Copy link

@M27Mangan M27Mangan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Good work!

@M27Mangan M27Mangan removed their assignment Jan 31, 2024
@M27Mangan M27Mangan added the UI Tasks related to the user interface (UI) or frontend development label Jan 31, 2024
@ekraffmiller ekraffmiller self-assigned this Jan 31, 2024
@ekraffmiller
Copy link
Contributor

looks good! Merging

@ekraffmiller ekraffmiller merged commit 6a718db into develop Jan 31, 2024
10 of 14 checks passed
@MellyGray MellyGray deleted the fix/279-loading-text-appears-when-navigating branch February 1, 2024 14:11
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…en-navigating

279 - Fix remove loading text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Loading' text briefly appears when navigating from Home Page to View Dataset Page
4 participants