feat: introduce DatasetTypeDTO and remove optional from id property in DatasetType model#392
Merged
feat: introduce DatasetTypeDTO and remove optional from id property in DatasetType model#392
Conversation
…n DatasetType model
Contributor
Author
|
Merging as it's a typescript types only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new DTO interface used to define the object structure requested for creating a dataset type.
With this change we don't use the
DatasetTypeone for this same purpose and we just leave it for defining the structure of a dataset type after it was created.Suggestions on how to test this:
Check tests are passing.
Is there a release notes or changelog update needed for this change?:
No.