Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date format validation on create & update dataset #161

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Jul 16, 2024

What this PR does / why we need it:

Fixes date format validation.

Not all metadata fields of all metadata blocks expect a date in the YYYY-MM-DD format. There are metadata fields that expect other date formats, defined by the watermark.

Which issue(s) this PR closes:

Related Dataverse PRs:

N/A

Special notes for your reviewer:

The .gitignore modification is to ignore my vscode folder on my end where I'm using settings to auto format on save with prettier.

Suggestions on how to test this:

Visual inspection and run tests.

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@g-saracca g-saracca added bug Something isn't working Size: 3 A percentage of a sprint. 2.1 hours. SPA: Create Dataset Page SPA: Edit Dataset Page GREI Re-arch GREI re-architecture-related labels Jul 16, 2024
@ekraffmiller ekraffmiller self-assigned this Jul 24, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ekraffmiller ekraffmiller removed their assignment Jul 25, 2024
@GPortas GPortas self-assigned this Jul 31, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GPortas GPortas merged commit ceba6f3 into develop Jul 31, 2024
5 checks passed
@GPortas GPortas deleted the fix/157-date-format-validation branch July 31, 2024 13:47
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 3 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Create Dataset Page SPA: Edit Dataset Page SPA.Q3 Not related to any specific Q3 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Fix date format validation in create/edit dataset use cases
3 participants