-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds create collection use case #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taverse-client-javascript into 75-create-collection-use-case
GPortas
added
GREI Re-arch
GREI re-architecture-related
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Create Collection Page
labels
Jun 13, 2024
g-saracca
previously approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… into 75-create-collection-use-case
g-saracca
approved these changes
Jun 26, 2024
I had an error running the tests locally, created an issue for it here:#160. Approving this since the tests are passing in Github actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GREI Re-arch
GREI re-architecture-related
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Create Collection Page
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds use case for creating a collection.
For now the use case only covers collection required fields. We will need to extend this use case to support the rest of the collection info available on create.
Which issue(s) this PR closes:
Related Dataverse PRs:
Suggestions on how to test this:
Visual inspection and test execution