Adds use cases for uploading files through direct upload API #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into 152-direct-upload-files-use-case
GPortas
added
SPA: File Upload Page
GREI Re-arch
GPortas
changed the title
This was referenced Jun 10, 2024
g-saracca
requested changes
Jun 12, 2024
src/files/infra/repositories/transformers/fileUploadDestinationsTransformers.ts
Outdated
Show resolved
Hide resolved
|
Looks good and all tests pass, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR includes the use cases to support file uploads through the Direct Upload API. These use cases are entirely based on the Direct Upload API, so for the review of this PR, I recommend to rely on: https://guides.dataverse.org/en/latest/developers/s3-direct-upload-api.html
Which issue(s) this PR closes:
Related PRs:
Special notes for your reviewer:
This PR does not incorporate use case functional tests because the tests are run outside the container network and we encountered issues with hostnames not being recognized for the generated destination URLs. However, coverage is still high, over 95%, and the different scenarios are tested with integration and unit tests.
Suggestions on how to test this:
Visual inspection of the code and unit and integration tests execution.
Additional documentation: