Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

121 - Modify GetAllDatasetPreviews use case to accept collectionId #124

Conversation

MellyGray
Copy link
Contributor

What this PR does / why we need it:

This PR adds the collectionId argument to the GetAllDatasetPreviews use case so that the datasets results can be filtered by collection.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

  1. Visual inspection of the code
  2. Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

Additional documentation:

@MellyGray MellyGray linked an issue Feb 6, 2024 that may be closed by this pull request
@MellyGray MellyGray added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: Collection Page labels Feb 6, 2024
@GPortas GPortas self-assigned this Feb 26, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MellyGray Can you please resolve conflicts and update the docs to include the new optional collectionId use case param?

@GPortas GPortas assigned MellyGray and unassigned GPortas Feb 26, 2024
…vascript into feature/121-modify-getalldatasetpreviews-use-case-to-accept-collection-id
…vascript into feature/121-modify-getalldatasetpreviews-use-case-to-accept-collection-id
@MellyGray
Copy link
Contributor Author

@GPortas I resolved the conflicts and update the docs

@MellyGray MellyGray assigned GPortas and unassigned MellyGray Feb 26, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GPortas GPortas merged commit ea23def into develop Feb 26, 2024
1 check passed
@GPortas GPortas deleted the feature/121-modify-getalldatasetpreviews-use-case-to-accept-collection-id branch February 26, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify GetAllDatasetPreviews use case to accept collection id
2 participants